Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR][NOTEST] - Logfile configuration with new disk #9944

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Feb 21, 2020

Purpose or Intent

PRT Run

{ {pytest: ./cfme/tests/cli/test_appliance_console.py::test_appliance_console_logfile_config_reboot --long-running -v}}

cfme/tests/cli/test_appliance_console.py Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Show resolved Hide resolved
Comment on lines +1621 to +1740
1. get appliance with extra disk
2. set "logfile configuration"
3. set "Harden Appliance Using SCAP Configuration"
4. reboot appliance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could be a part of the setup and 'Execute df -h command and check log files for new disk' or something like that could be a testStep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added df -h to testSteps and reboot appliance is not setup part, it is just one step of test case,

@valaparthvi valaparthvi added the manual For things concerning manual test definitions label Feb 21, 2020
@valaparthvi valaparthvi changed the title [NOTEST] - Logfile configuration with new disk [WIPTEST][NOTEST] - Logfile configuration with new disk Feb 21, 2020
cfme/tests/cli/test_appliance_console.py Show resolved Hide resolved
def test_appliance_console_logfile_config_reboot():
"""
test to verify logfiles disk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would format this line like this:

"""Test to verify logfiles disk.....
....
...

And remove line(1610)

assignee: dgaikwad
casecomponent: Appliance
caseimportance: high
caseposneg: negative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove caseimportance. By default - it is high

@dgaikwad dgaikwad force-pushed the logfile_path branch 2 times, most recently from 284ab09 to e405881 Compare February 27, 2020 07:31
@dgaikwad dgaikwad changed the title [WIPTEST][NOTEST] - Logfile configuration with new disk [RFR][NOTEST] - Logfile configuration with new disk Mar 3, 2020
@dajoRH dajoRH removed the WIP-testing label Mar 3, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, they look good.


@pytest.mark.tier(0)
@pytest.mark.manual
@pytest.mark.meta(automates=[1720223])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this test case has not been automated yet, you should be using coverage instead of automates. You can change it back when you automate the test case.

Polarion:
assignee: dgaikwad
casecomponent: Appliance
caseposneg: negative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you marked this with caseposneg: negative? It looks like a positive test case to me.

@valaparthvi valaparthvi changed the title [RFR][NOTEST] - Logfile configuration with new disk [1LP][RFR][NOTEST] - Logfile configuration with new disk Mar 3, 2020
@mshriver mshriver self-assigned this Mar 3, 2020
@mshriver
Copy link
Member

mshriver commented Mar 3, 2020

PRT results not necessary, as this is a new manual test. PRT does show that the module continues to collect automated tests correctly.

@mshriver mshriver merged commit 1aa43f6 into ManageIQ:master Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok manual For things concerning manual test definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants