-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR][NOTEST] - Logfile configuration with new disk #9944
Conversation
1. get appliance with extra disk | ||
2. set "logfile configuration" | ||
3. set "Harden Appliance Using SCAP Configuration" | ||
4. reboot appliance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this could be a part of the setup
and 'Execute df -h
command and check log files for new disk' or something like that could be a testStep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added df -h
to testSteps and reboot appliance
is not setup part, it is just one step of test case,
def test_appliance_console_logfile_config_reboot(): | ||
""" | ||
test to verify logfiles disk | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would format this line like this:
"""Test to verify logfiles disk.....
....
...
And remove line(1610)
assignee: dgaikwad | ||
casecomponent: Appliance | ||
caseimportance: high | ||
caseposneg: negative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove caseimportance. By default - it is high
284ab09
to
e405881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, they look good.
|
||
@pytest.mark.tier(0) | ||
@pytest.mark.manual | ||
@pytest.mark.meta(automates=[1720223]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test case has not been automated yet, you should be using coverage
instead of automates
. You can change it back when you automate the test case.
Polarion: | ||
assignee: dgaikwad | ||
casecomponent: Appliance | ||
caseposneg: negative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you marked this with caseposneg: negative
? It looks like a positive test case to me.
PRT results not necessary, as this is a new manual test. PRT does show that the module continues to collect automated tests correctly. |
Purpose or Intent
PRT Run
{ {pytest: ./cfme/tests/cli/test_appliance_console.py::test_appliance_console_logfile_config_reboot --long-running -v}}