[1LP][RFR] Update snapshot tests to use create_vm fixture #9942

prichard77 · 2020-02-20T22:05:51Z

Purpose or Intent

Updating tests in test_snapshot.py to use new create_vm global fixture.

PRT Run

The function test_verify_revert_snapshot fails for rhv providers. This was failing before the update to create_vm and is not caused by it. I am going to begin work on fixing test_verify_revert_snapshot for rhv providers in another PR shortly.

…ut_description tests to use create_vm

…xtures

prichard77 · 2020-02-23T06:42:49Z

PRT is invalid for some reason. I am not sure why. I have initiated a rerun. I tested each test function in test_snpshot.py locally and all passed except for test_verify_revert_snapshot, as I mentioned in earlier comment. I'll be fixing this soon.

prichard77 · 2020-02-23T23:02:46Z

PRT keeps going to Invalid. Might be an issue with it. I'll bring it up Monday. No need to bother anyone on a Sunday.

dajoRH · 2020-02-24T16:30:54Z

I detected some fixture changes in commit f3f27dd

The local fixture create_vm is used in the following files:

cfme/tests/infrastructure/test_vm_clone.py
- test_vm_clone
- test_vm_clone_neg

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

prichard77 · 2020-02-24T16:33:51Z

I updated create_vm by wrapping up vm.cleanup_on_provider in a wait_for with HandleException=True. I can add exception handling directly to cleanup_on_provider in another PR or do it here?

cfme/tests/infrastructure/test_vm_clone.py

john-dupuy

Just one question about your change to the local create_vm in test_vm_clone.py. Changes LGTM though and PRT results show that the vm-name has your nic in it. PRT failures are not a result of changes here.

…up_on_provider

prichard77 · 2020-02-25T16:50:22Z

I added a wait_for to added a wait_for to cleanup_on_provide that has handle_exception=True by default. It was suggested we use kwarg to control if we want to handle exceptions in the cleanup, but I don't know how this get used as we do not call create_vm directly (it's a fixture).

dgaikwad · 2020-02-26T08:41:04Z

@prichard77 Please check PRT failure

jarovo

Nothing much going on in this PR, mostly just s/name/othername/g

Good job anyway. It seems like the create_vm gets some momentum.

prichard77 · 2020-02-26T13:33:21Z

I added a wait_for to added a wait_for to cleanup_on_provide that has handle_exception=True by default. It was suggested we use kwarg to control if we want to handle exceptions in the cleanup, but I don't know how this get used as we do not call create_vm directly (it's a fixture).

john-dupuy · 2020-02-26T15:22:56Z

cfme/common/vm.py

        """Clean up entity on the provider if it has been created on the provider

        Helper method to avoid NotFoundError's during test case tear down.
        """
        if self.exists_on_provider:
-            self.mgmt.cleanup()
+            wait_for(lambda: self.mgmt.cleanup, handle_exception=handle_cleanup_exception,
+                     timeout=900)


This is a lengthy timeout, if cleanup fails for some reason and we are stuck because handle_exception=True, we could spend 15 min here. I think 300 or maybe even 180 would be fine here.

Reduced to 300.

john-dupuy

1 question about timeout, but LGTM, moving to [1LP][WIPTEST]

jawatts

Looks good! waiting on evaluation of PRT failures

prichard77 · 2020-02-28T18:11:49Z

I mentioned in earlier comments that AFAIK the failures are for tests with BZs against them and/or were failing before the change was made to use create_vm.

jawatts · 2020-02-28T18:28:12Z

Thanks PJ!

prichard77 · 2020-03-03T16:38:34Z

What are we waiting on here? i have added several comments on the PRT results and we have 3 approvals. Did I miss something?

mshriver · 2020-03-03T22:04:37Z

@prichard77 it was 1LPWIPTEST during freeze on Friday, and was marked 1LPRFR at 5:24PM EST.

Nothing gets merged until the release is tagged, which it was last night.

2nd level reviewers haven't come back to the RFR lists to re-review yet.

Update test_revert_active_snapshot to use create_vm fixture

0698446

dajoRH added needs-lint WIP labels Feb 20, 2020

prichard77 added 4 commits February 21, 2020 16:38

Update test_revert_to_active_vm to use create_vm fixture

999ce34

Update memory_checkbox, crud, delete_active_vm_snapshot, create_witho…

68abada

…ut_description tests to use create_vm

Update remaining small_template tests to use create_vm

33cff2d

Update test_verify_revert_snapshot to use create_vm and remove old fi…

f0eeb13

…xtures

dajoRH added lint-ok and removed needs-lint labels Feb 23, 2020

Remove unused import cfme.utils.generators.random_vm_name

c38eeba

prichard77 changed the title ~~[WIP] Update snapshot tests to use create_vm fixture~~ [WIPTEST] Update snapshot tests to use create_vm fixture Feb 23, 2020

dajoRH added WIP-testing and removed WIP labels Feb 23, 2020

prichard77 changed the title ~~[WIPTEST] Update snapshot tests to use create_vm fixture~~ [RFR] Update snapshot tests to use create_vm fixture Feb 23, 2020

dajoRH removed the WIP-testing label Feb 23, 2020

Add exception handling to cleanup in create_vm

f3f27dd

john-dupuy reviewed Feb 25, 2020

View reviewed changes

cfme/tests/infrastructure/test_vm_clone.py Outdated Show resolved Hide resolved

john-dupuy reviewed Feb 25, 2020

View reviewed changes

Remove update to wrong create_vm and added waait_for wrapper to clean…

47ec252

…up_on_provider

jarovo approved these changes Feb 26, 2020

View reviewed changes

john-dupuy reviewed Feb 26, 2020

View reviewed changes

john-dupuy approved these changes Feb 26, 2020

View reviewed changes

john-dupuy changed the title ~~[RFR] Update snapshot tests to use create_vm fixture~~ [1LP][WIPTEST] Update snapshot tests to use create_vm fixture Feb 26, 2020

dajoRH added the WIP-testing label Feb 26, 2020

Reduce timeout in cleanup_on_provider to 300

73539f2

prichard77 changed the title ~~[1LP][WIPTEST] Update snapshot tests to use create_vm fixture~~ [1LP][RFR] Update snapshot tests to use create_vm fixture Feb 26, 2020

dajoRH removed the WIP-testing label Feb 26, 2020

jawatts self-assigned this Feb 28, 2020

jawatts added the enhancement label Feb 28, 2020

jawatts approved these changes Feb 28, 2020

View reviewed changes

jawatts changed the title ~~[1LP][RFR] Update snapshot tests to use create_vm fixture~~ [1LP][WIPTEST] Update snapshot tests to use create_vm fixture Feb 28, 2020

dajoRH added the WIP-testing label Feb 28, 2020

prichard77 changed the title ~~[1LP][WIPTEST] Update snapshot tests to use create_vm fixture~~ [1LP][RFR] Update snapshot tests to use create_vm fixture Feb 28, 2020

dajoRH removed the WIP-testing label Feb 28, 2020

mshriver approved these changes Mar 3, 2020

View reviewed changes

mshriver merged commit 012785f into ManageIQ:master Mar 3, 2020

prichard77 deleted the useCreateVM4snap branch March 10, 2020 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] Update snapshot tests to use create_vm fixture #9942

[1LP][RFR] Update snapshot tests to use create_vm fixture #9942

prichard77 commented Feb 20, 2020 •

edited

Loading

prichard77 commented Feb 23, 2020 •

edited

Loading

prichard77 commented Feb 23, 2020

dajoRH commented Feb 24, 2020

prichard77 commented Feb 24, 2020

john-dupuy left a comment

prichard77 commented Feb 25, 2020

dgaikwad commented Feb 26, 2020

jarovo left a comment

prichard77 commented Feb 26, 2020

john-dupuy Feb 26, 2020

prichard77 Feb 26, 2020

john-dupuy left a comment

jawatts left a comment

prichard77 commented Feb 28, 2020

jawatts commented Feb 28, 2020

prichard77 commented Mar 3, 2020

mshriver commented Mar 3, 2020

[1LP][RFR] Update snapshot tests to use create_vm fixture #9942

[1LP][RFR] Update snapshot tests to use create_vm fixture #9942

Conversation

prichard77 commented Feb 20, 2020 • edited Loading

Purpose or Intent

PRT Run

prichard77 commented Feb 23, 2020 • edited Loading

prichard77 commented Feb 23, 2020

dajoRH commented Feb 24, 2020

prichard77 commented Feb 24, 2020

john-dupuy left a comment

Choose a reason for hiding this comment

prichard77 commented Feb 25, 2020

dgaikwad commented Feb 26, 2020

jarovo left a comment

Choose a reason for hiding this comment

prichard77 commented Feb 26, 2020

john-dupuy Feb 26, 2020

Choose a reason for hiding this comment

prichard77 Feb 26, 2020

Choose a reason for hiding this comment

john-dupuy left a comment

Choose a reason for hiding this comment

jawatts left a comment

Choose a reason for hiding this comment

prichard77 commented Feb 28, 2020

jawatts commented Feb 28, 2020

prichard77 commented Mar 3, 2020

mshriver commented Mar 3, 2020

prichard77 commented Feb 20, 2020 •

edited

Loading

prichard77 commented Feb 23, 2020 •

edited

Loading