[1LP][RFR] Fix AttributeError on test_git_import module import #9909
Conversation
mshriver
changed the title
mshriver
force-pushed
the
handle-attributeerror
branch
from
c89fe52
to
2854dd4
Compare
mshriver
changed the title
|
|
||
|
|
||
| @pytest.fixture | ||
| def imported_domain(appliance): | ||
| if GIT_REPO_URL is None: |
There was a problem hiding this comment.
Could also do this via a separate fixture instead of having to re-use the same block?
|
I detected some fixture changes in commit 2854dd4 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
|
@mshriver Since this key, value pair is also in the template yamls, is it necessary to check this? |
|
@john-dupuy I'd say yes - because its done on module import. |
There was a problem hiding this comment.
@mshriver Thanks for this PR :)
But yeah, I am agree to create separate fixture for that block of code to avoid duplication of code.
Can we add that fixture in this PR?
|
|
||
|
|
||
| @pytest.fixture | ||
| def imported_domain(appliance): | ||
| if GIT_REPO_URL is None: | ||
| pytest.skip('No automate repo url available at ' | ||
| 'cfme_data.automate_links.datastore_repositories.manageiq_automate') | ||
| repo = appliance.collections.automate_import_exports.instantiate( |
There was a problem hiding this comment.
Optional:
Can we modify this message:
No automate datastore is available at URL - cfme_data.automate_links.datastore_repositories.manageiq_automate'
ganeshhubale
changed the title
There was a problem hiding this comment.
@ganeshhubale can you take care of fixture. For now its LGTM 👍
{{ pytest: cfme/tests/automate/test_git_import.py::test_automate_git_domain_removed_from_disk }}