This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automate: test_reports_timezone #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
added
enhancement
test-automation
valaparthvi
force-pushed
the
sr_dynamic_tz
branch
from
a283991 to
729e623
Compare
valaparthvi
changed the title
valaparthvi
changed the title
john-dupuy
approved these changes
Feb 6, 2020
| @cached_property | ||
| def queued_datetime_in_title(self): | ||
| return parsetime.from_american_with_utc(self.queued_datetime).to_saved_report_title_format() | ||
| delattr(self.appliance, "rest_api") |
There was a problem hiding this comment.
perhaps put a small comment about why you need to clear the cache.
john-dupuy
changed the title
digitronik
reviewed
Feb 7, 2020
| return cls._parse(cls.saved_report_title_format, time_string) | ||
| """ | ||
| return cls._parse( | ||
| f"{cls.saved_report_title_format} {get_time_difference(area)}", time_string |
There was a problem hiding this comment.
If area not found then it will formate "something None(area)". I think better to avoid this.
dajoRH
changed the title
valaparthvi
force-pushed
the
sr_dynamic_tz
branch
from
6d16070 to
49a31b5
Compare
valaparthvi
force-pushed
the
sr_dynamic_tz
branch
from
49a31b5 to
213cdf0
Compare
Small changes Requested changes
valaparthvi
force-pushed
the
sr_dynamic_tz
branch
from
213cdf0 to
011b2c8
Compare
valaparthvi
changed the title
|
I detected some fixture changes in commit 011b2c8 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
digitronik
approved these changes
Feb 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
test_reports_timezonecfme.utils.timeutil.parsetimeto be compatible with different timezones. This may not work in case the timezone is not found inpytzmodule.report_timezonetoSavedReportentity and modifyqueued_datetime_in_titleanddatetime_in_treeaccordingly.PRT Run
{{ pytest: cfme/tests/intelligence/reports/test_reports.py -k "test_reports_timezone" -vvv }}