[1LP][RFR] Fix product features for role used in v2v migration test #9902
Conversation
nachandr
changed the title
nachandr
force-pushed
the
fix_test_v2v_rbac
branch
from
a1f0042 to
ca0d1b4
Compare
nachandr
force-pushed
the
fix_test_v2v_rbac
branch
from
ca0d1b4 to
08dd9e1
Compare
nachandr
force-pushed
the
fix_test_v2v_rbac
branch
from
f876789 to
d53569c
Compare
nachandr
changed the title
| """ | ||
| Test migration with role-based access control | ||
| Test to verify that the Migration tab is available/unavailable in the UI with | ||
| role-based access control | ||
|
|
||
| Polarion: | ||
| assignee: sshveta |
There was a problem hiding this comment.
Please change the assignee to yourself
There was a problem hiding this comment.
Done.
Also, parametrized the test on 'migration_feature_availability_for_role'.
john-dupuy
changed the title
nachandr
changed the title
nachandr
force-pushed
the
fix_test_v2v_rbac
branch
from
504780c to
d1822c8
Compare
|
I detected some fixture changes in commit d1822c8 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
sshveta
changed the title
There was a problem hiding this comment.
Nice PR @nachandr 👍
LGTM; one suggestion and an optional comment.
| @@ -322,6 +322,33 @@ def _cleanup(): | |||
| pass | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def setup_user_for_v2v_migration(appliance, new_credential): | |||
There was a problem hiding this comment.
this is a good fixture 👍
@sshveta and @nachandr what you think to put this as a global fixture
https://github.com/ManageIQ/integration_tests/blob/master/cfme/fixtures/v2v_fixtures.py
There was a problem hiding this comment.
@nachandr : Please check if there is already a fixture available like this . If not we can make it a global fixture .
Sure it can be used in all rbac tests
|
|
||
|
|
||
| @pytest.mark.parametrize('migration_feature_availability_for_role', ['disabled', 'enabled'], | ||
| ids=['disabled', 'enabled'], |
There was a problem hiding this comment.
optional: These are default ids as we are iterating over the same list ['disabled', 'enabled']
nachandr
force-pushed
the
fix_test_v2v_rbac
branch
from
7006617 to
6d94382
Compare
Purpose or Intent
PRT Run
{{pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k test_rbac --use-template-cache --provider-limit 2 --use-provider rhv43 --use-provider vsphere65-nested -qsvv }}