Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]Adding automation for Customer BZ1644770 #9901

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

kedark3
Copy link
Contributor

@kedark3 kedark3 commented Feb 4, 2020

Purpose or Intent

  • Adding tests for Customer BZ 1644770

PRT Run

{{pytest: cfme/tests/infrastructure/test_vmware_provider.py -k 'test_vm_remove_from_inventory_orphan or test_delete_vm_archive' -v}}

@dajoRH dajoRH added the lint-ok label Feb 4, 2020
@john-dupuy john-dupuy added test-automation To be applied on PR's which are automating existing manual cases new-test-or-feature and removed test-automation To be applied on PR's which are automating existing manual cases labels Feb 4, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request to add some expected results, since the test steps are included.

Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tests failed on PRT though
" """
create_vm.mgmt.delete()
quadicon = create_vm.find_quadicon(from_any_provider=True)

  assert quadicon.data['power_state'] == 'archived'

E KeyError: 'power_state'
"

@sshveta sshveta changed the title [RFR]Adding automation for Customer BZ1644770 [1LP][RFR]Adding automation for Customer BZ1644770 Feb 4, 2020
@sshveta sshveta changed the title [1LP][RFR]Adding automation for Customer BZ1644770 [RFR]Adding automation for Customer BZ1644770 Feb 4, 2020
@sshveta sshveta changed the title [RFR]Adding automation for Customer BZ1644770 [WIPTEST]Adding automation for Customer BZ1644770 Feb 4, 2020
@john-dupuy john-dupuy changed the title [WIPTEST]Adding automation for Customer BZ1644770 [1LP][WIPTEST]Adding automation for Customer BZ1644770 Feb 5, 2020
@kedark3
Copy link
Contributor Author

kedark3 commented Feb 5, 2020

@sshveta 1 out of 2 tests are failing in latest run 749 as it needs Wrapanapi PR RedHatQE/wrapanapi/pull/436 to be merged.

@mshriver
Copy link
Member

mshriver commented Feb 5, 2020

@kedark3 wrapanapi 3.5.5 has been tagged, should be available on pypi shortly.

@mshriver mshriver self-assigned this Feb 5, 2020
@dajoRH dajoRH changed the title [1LP][WIPTEST]Adding automation for Customer BZ1644770 [1LP][WIP]Adding automation for Customer BZ1644770 Feb 5, 2020
@kedark3 kedark3 changed the title [1LP][WIP]Adding automation for Customer BZ1644770 [1LP][RFR]Adding automation for Customer BZ1644770 Feb 5, 2020
@kedark3
Copy link
Contributor Author

kedark3 commented Feb 5, 2020

@mshriver seems like pip didn't pick up latest package yet for wrapanapi release.

3.VM is Archived in CFME
"""
create_vm.mgmt.delete()
create_vm.wait_for_vm_state_change(from_any_provider=True, desired_state='archived')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap this in a try/except to call pytest.fail on the TimedOutError exception please?

@dajoRH dajoRH changed the title [1LP][RFR]Adding automation for Customer BZ1644770 [1LP][WIP]Adding automation for Customer BZ1644770 Feb 7, 2020
@dajoRH dajoRH added needs-lint and removed lint-ok labels Feb 7, 2020
@kedark3 kedark3 changed the title [1LP][WIP]Adding automation for Customer BZ1644770 [1LP][RFR]Adding automation for Customer BZ1644770 Feb 7, 2020
@mshriver mshriver merged commit abbf1c1 into ManageIQ:master Feb 7, 2020
@dajoRH dajoRH added lint-ok and removed needs-lint labels Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants