-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Automating service dialog default selection test #9899
Conversation
a79ec27
to
27bcf17
Compare
27bcf17
to
eb4779f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment Niyaz , otherwise looks good
view = navigate_to(service_catalogs, "Order") | ||
assert ( | ||
view.fields("enviroment").read() == environment and | ||
view.fields("intance").read() == vm_size and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo "instance
eb4779f
to
8cdaf42
Compare
I detected some fixture changes in commit 8cdaf42 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
view.fields("instance").read() == vm_size and | ||
view.fields("network").read() == network and | ||
view.fields("number_disk").read() == additional_disks | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to cancel the order after the test otherwise it will wait at the page ?
Just check once in automation .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, We don't need to cancel the order. It doesn't waits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR @niyazRedhat
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_dialog_default_value_selection --long-running }}