Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automating service dialog default selection test #9899

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

niyazRedhat
Copy link
Contributor

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_dialog_default_value_selection --long-running }}

@niyazRedhat niyazRedhat changed the title [WIPTEST] Automating service dialog default selection test [RFR] Automating service dialog default selection test Feb 4, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 4, 2020
Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment Niyaz , otherwise looks good

view = navigate_to(service_catalogs, "Order")
assert (
view.fields("enviroment").read() == environment and
view.fields("intance").read() == vm_size and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "instance

@dajoRH
Copy link
Contributor

dajoRH commented Feb 5, 2020

I detected some fixture changes in commit 8cdaf42

The local fixture custom_categories is used in the following files:

  • cfme/tests/services/test_dialog_element_in_catalog.py
    • test_dialog_default_value_selection

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

view.fields("instance").read() == vm_size and
view.fields("network").read() == network and
view.fields("number_disk").read() == additional_disks
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to cancel the order after the test otherwise it will wait at the page ?
Just check once in automation .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, We don't need to cancel the order. It doesn't waits

@john-dupuy john-dupuy added the test-automation To be applied on PR's which are automating existing manual cases label Feb 6, 2020
@john-dupuy john-dupuy changed the title [RFR] Automating service dialog default selection test [WIPTEST] Automating service dialog default selection test Feb 6, 2020
@sshveta sshveta changed the title [WIPTEST] Automating service dialog default selection test [RFR] Automating service dialog default selection test Feb 6, 2020
@sshveta sshveta changed the title [RFR] Automating service dialog default selection test [1LP][RFR] Automating service dialog default selection test Feb 6, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 6, 2020
@digitronik digitronik self-assigned this Feb 11, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @niyazRedhat

@digitronik digitronik merged commit 51b5a4b into ManageIQ:master Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants