-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Added automation coverage for BZ1734446. #9883
Conversation
For this test, I have raised separate PR to have playbook placed in sub folders in our Ansible Playbook testing repository. ManageIQ/integration_tests_playbooks#7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is nice and simple, but I have one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test case looks good, but can you check PRT @sbulage? Failing with
> raise ItemNotFound("Entity {keys} isn't found on this page".format(keys=keys))
E cfme.exceptions.ItemNotFound: Entity {'name': 'hello_world.yml'} isn't found on this page
widgetastic_manageiq/__init__.py:3514: ItemNotFound
ItemNotFound
b"Entity {'name': 'hello_world.yml'} isn't found on this page"
In 5.10
112f7db
to
ec89d4c
Compare
ec89d4c
to
a7383cb
Compare
Newly written test |
9725660
to
d50b750
Compare
@john-dupuy It was failing due to absence of exact playbook name gathered after adding Ansible Playbook repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for all the changes :)
For Reviewer's ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR 👍
just one optional comment.
d50b750
to
ed7ff27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure not related to changes. LGTM 👍
Purpose or Intent
PRT Run
{pytest: cfme/tests/ansible/test_embedded_ansible_basic.py -k "test_embedded_ansible_repository_playbook_sub_dir" --long-running -svvvv}