Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Added automation coverage for BZ1734446. #9883

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Jan 28, 2020

Purpose or Intent

  • Automated Embedded Ansible BZ1734446 which find playbook from the sub-directories of Ansible Playbook repository.

PRT Run

{pytest: cfme/tests/ansible/test_embedded_ansible_basic.py -k "test_embedded_ansible_repository_playbook_sub_dir" --long-running -svvvv}

@sbulage
Copy link
Contributor Author

sbulage commented Jan 28, 2020

For this test, I have raised separate PR to have playbook placed in sub folders in our Ansible Playbook testing repository. ManageIQ/integration_tests_playbooks#7

@sbulage sbulage changed the title [WIPTEST] Added automation coverage for BZ1734446. [RFR] Added automation coverage for BZ1734446. Jan 28, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is nice and simple, but I have one suggestion.

@john-dupuy john-dupuy added test-automation To be applied on PR's which are automating existing manual cases new-test-or-feature and removed test-automation To be applied on PR's which are automating existing manual cases labels Jan 28, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case looks good, but can you check PRT @sbulage? Failing with

>           raise ItemNotFound("Entity {keys} isn't found on this page".format(keys=keys))
E           cfme.exceptions.ItemNotFound: Entity {'name': 'hello_world.yml'} isn't found on this page

widgetastic_manageiq/__init__.py:3514: ItemNotFound
ItemNotFound
b"Entity {'name': 'hello_world.yml'} isn't found on this page"

In 5.10

@mshriver mshriver changed the title [RFR] Added automation coverage for BZ1734446. [WIPTEST] Added automation coverage for BZ1734446. Jan 31, 2020
@sbulage sbulage force-pushed the ansible_auto_BZ1734446 branch 2 times, most recently from 112f7db to ec89d4c Compare February 4, 2020 18:11
@sbulage sbulage force-pushed the ansible_auto_BZ1734446 branch from ec89d4c to a7383cb Compare February 5, 2020 10:17
@sbulage
Copy link
Contributor Author

sbulage commented Feb 5, 2020

Newly written test test_embedded_ansible_repository_playbook_sub_dir is running without any issue on PRT. Only one test is case is failing on CF5.10 related to Zone.

@sbulage sbulage changed the title [WIPTEST] Added automation coverage for BZ1734446. [RFR] Added automation coverage for BZ1734446. Feb 5, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 5, 2020
@sbulage sbulage force-pushed the ansible_auto_BZ1734446 branch from 9725660 to d50b750 Compare February 5, 2020 14:49
@sbulage
Copy link
Contributor Author

sbulage commented Feb 5, 2020

Test case looks good, but can you check PRT @sbulage? Failing with

>           raise ItemNotFound("Entity {keys} isn't found on this page".format(keys=keys))
E           cfme.exceptions.ItemNotFound: Entity {'name': 'hello_world.yml'} isn't found on this page

widgetastic_manageiq/__init__.py:3514: ItemNotFound
ItemNotFound
b"Entity {'name': 'hello_world.yml'} isn't found on this page"

In 5.10

@john-dupuy It was failing due to absence of exact playbook name gathered after adding Ansible Playbook repository.
I missed that part as I was checking this with my local Ansible Repository.

Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for all the changes :)

@valaparthvi valaparthvi changed the title [RFR] Added automation coverage for BZ1734446. [1LP][RFR] Added automation coverage for BZ1734446. Feb 6, 2020
@sbulage
Copy link
Contributor Author

sbulage commented Feb 6, 2020

Newly written test test_embedded_ansible_repository_playbook_sub_dir is running without any issue on PRT. Only one test is case is failing on CF5.10 related to Zone.

For Reviewer's ^^

Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 👍
just one optional comment.

@digitronik digitronik self-assigned this Feb 7, 2020
@sbulage sbulage force-pushed the ansible_auto_BZ1734446 branch from d50b750 to ed7ff27 Compare February 10, 2020 06:56
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure not related to changes. LGTM 👍

@digitronik digitronik merged commit 357499e into ManageIQ:master Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants