Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Removed BZ 1752875 blocker because won't fix. #9879

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

mayurilahane
Copy link
Contributor

@mayurilahane mayurilahane commented Jan 27, 2020

Purpose or Intent

Test case for Automate domain is failing because of BZ 1752875 WONTFIX, hence removing BZ blocker from test.
Fixed Error:

E            +      where ManageIQTree('ae_tree') = <Accordion 'Datastore'>.tree
E            +        where <Accordion 'Datastore'> = <cfme.automate.explorer.domain.DomainDetailsView object at 0x7ff035d98790>.datastore

cfme/tests/automate/test_domain.py:649: AssertionError
AssertionError
b"assert False\n +  where False = <bound method BootstrapTreeview.has_path of ManageIQTree('ae_tree')>('Datastore', 'bz_1752875', 'System', 'Request')\n +    where <bound method BootstrapTreeview.has_path of ManageIQTree('ae_tree')> = ManageIQTree('ae_tree').has_path\n +      where ManageIQTree('ae_tree') = <Accordion 'Datastore'>.tree\n +        where <Accordion 'Datastore'> = <cfme.automate.explorer.domain.DomainDetailsView object at 0x7ff035d98790>.datastore"

PRT Run

{{ pytest: cfme/tests/automate/test_domain.py::test_existing_domain_child_override -svvv }}

@ganeshhubale
Copy link
Member

@mayurilahane You have to sign the commit. Because of unverified commit, PRT is not running.

@mayurilahane mayurilahane force-pushed the first_pr_fix branch 7 times, most recently from 1b1583a to 9e2ffb4 Compare January 28, 2020 07:07
@mayurilahane mayurilahane changed the title [WIPTEST] Removed BZ 1752875 blocker because won't fix. [RFR] Removed BZ 1752875 blocker because won't fix. Jan 28, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion as pointed by @ganeshhubale, you will need to change the testSteps and expectedResults for 6 here.

Congrats on your first PR! :D

@valaparthvi valaparthvi changed the title [RFR] Removed BZ 1752875 blocker because won't fix. [WIPTEST] Removed BZ 1752875 blocker because won't fix. Jan 28, 2020
@mayurilahane mayurilahane changed the title [WIPTEST] Removed BZ 1752875 blocker because won't fix. [RFR] Removed BZ 1752875 blocker because won't fix. Jan 28, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] Removed BZ 1752875 blocker because won't fix. [1LP][RFR] Removed BZ 1752875 blocker because won't fix. Jan 28, 2020
Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this test cleanup, and congrats on your first contribution! Welcome to the team :)

@mshriver mshriver merged commit 8595912 into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants