This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Removed BZ 1752875 blocker because won't fix. #9879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mayurilahane You have to sign the commit. Because of |
mayurilahane
force-pushed
the
first_pr_fix
branch
7 times, most recently
from
January 28, 2020 07:07
1b1583a
to
9e2ffb4
Compare
mayurilahane
force-pushed
the
first_pr_fix
branch
from
January 28, 2020 10:10
9e2ffb4
to
6c2dc9e
Compare
mayurilahane
changed the title
[WIPTEST] Removed BZ 1752875 blocker because won't fix.
[RFR] Removed BZ 1752875 blocker because won't fix.
Jan 28, 2020
valaparthvi
suggested changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One suggestion as pointed by @ganeshhubale, you will need to change the testSteps and expectedResults for 6 here.
Congrats on your first PR! :D
valaparthvi
changed the title
[RFR] Removed BZ 1752875 blocker because won't fix.
[WIPTEST] Removed BZ 1752875 blocker because won't fix.
Jan 28, 2020
mayurilahane
changed the title
[WIPTEST] Removed BZ 1752875 blocker because won't fix.
[RFR] Removed BZ 1752875 blocker because won't fix.
Jan 28, 2020
ganeshhubale
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
ganeshhubale
changed the title
[RFR] Removed BZ 1752875 blocker because won't fix.
[1LP][RFR] Removed BZ 1752875 blocker because won't fix.
Jan 28, 2020
mshriver
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this test cleanup, and congrats on your first contribution! Welcome to the team :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Test case for Automate domain is failing because of BZ 1752875 WONTFIX, hence removing BZ blocker from test.
Fixed Error:
PRT Run
{{ pytest: cfme/tests/automate/test_domain.py::test_existing_domain_child_override -svvv }}