Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Test for Embedded Ansible repository refresh #9868

Merged
merged 3 commits into from
Feb 7, 2020
Merged

[1LP][RFR] Test for Embedded Ansible repository refresh #9868

merged 3 commits into from
Feb 7, 2020

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Jan 23, 2020

Purpose or Intent

  • Automated manual test for Refresh Embedded Ansible repository.
  • Removed manual tests.

PRT Run

{{pytest: cfme/tests/ansible/test_embedded_ansible_basic.py -k "test_embedded_ansible_repository_refresh" --long-running -svvvv }}

@sbulage sbulage changed the title [WIPTEST] Test for Embedded Ansible repository refresh [RFR] Test for Embedded Ansible repository refresh Jan 24, 2020
@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label Jan 24, 2020
john-dupuy
john-dupuy reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbulage Can you check PRT results for 5.10? Also, I am not sure how this automated test case is automating the manual case test_embed_tower_ui_requests_notifications_negative. Is that test case not relevant anymore?

@john-dupuy john-dupuy changed the title [RFR] Test for Embedded Ansible repository refresh [WIPTEST] Test for Embedded Ansible repository refresh Jan 24, 2020
@sbulage
Copy link
Contributor Author

sbulage commented Jan 27, 2020 •
edited
Loading

@sbulage Can you check PRT results for 5.10? Also, I am not sure how this automated test case is automating the manual case test_embed_tower_ui_requests_notifications_negative. Is that test case not relevant anymore?

@john-dupuy Above test test_embed_tower_ui_requests_notifications_negative case can't be automate due to notification are disappearing immediately, hence removing those tests. Also, CF5.10 results are passing in previous PRT runs.

@sbulage sbulage changed the title [WIPTEST] Test for Embedded Ansible repository refresh [RFR] Test for Embedded Ansible repository refresh Jan 27, 2020
@digitronik
Copy link
Contributor

@sbulage I would mark such test case manual only... I would not remove test scenario only because we can not automate.

@digitronik digitronik changed the title [RFR] Test for Embedded Ansible repository refresh [WIP] Test for Embedded Ansible repository refresh Jan 28, 2020
@dajoRH dajoRH added the WIP label Jan 28, 2020
digitronik
digitronik reviewed Jan 28, 2020
View reviewed changes
cfme/tests/ansible/test_embedded_ansible_basic.py Outdated
view = navigate_to(ansible_repository, "Details")
view.toolbar.configuration.item_select('Refresh this Repository', handle_alert=True)

wait_for(view.toolbar.refresh.click, delay=2, timeout=5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why we are using this wait_for?:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After initializing Refresh this Repository it will take minor time to reflect, to wait for few seconds, I have added wait_for.

cfme/tests/ansible/test_embedded_ansible_basic.py Outdated Show resolved Hide resolved
@sbulage sbulage changed the title [WIP] Test for Embedded Ansible repository refresh [RFR] Test for Embedded Ansible repository refresh Jan 28, 2020
@dajoRH dajoRH removed the WIP label Jan 28, 2020
@sbulage sbulage changed the title [RFR] Test for Embedded Ansible repository refresh [WIP] Test for Embedded Ansible repository refresh Jan 28, 2020
@dajoRH dajoRH added the WIP label Jan 28, 2020
@sbulage sbulage changed the title [WIP] Test for Embedded Ansible repository refresh [WIPTEST] Test for Embedded Ansible repository refresh Feb 4, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Feb 4, 2020
@sbulage sbulage changed the title [WIPTEST] Test for Embedded Ansible repository refresh [RFR] Test for Embedded Ansible repository refresh Feb 5, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 5, 2020
@valaparthvi valaparthvi changed the title [RFR] Test for Embedded Ansible repository refresh [1[RFR] Test for Embedded Ansible repository refresh Feb 5, 2020
@valaparthvi valaparthvi changed the title [1[RFR] Test for Embedded Ansible repository refresh [1LP][RFR] Test for Embedded Ansible repository refresh Feb 5, 2020
@digitronik digitronik added the manual For things concerning manual test definitions label Feb 7, 2020
@digitronik digitronik self-assigned this Feb 7, 2020
@digitronik digitronik merged commit 813e26b into ManageIQ:master Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy left review comments

@digitronik digitronik digitronik approved these changes

@valaparthvi valaparthvi valaparthvi approved these changes

@ganeshhubale ganeshhubale Awaiting requested review from ganeshhubale

Assignees

@digitronik digitronik

Labels
lint-ok manual For things concerning manual test definitions test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbulage @digitronik @valaparthvi @john-dupuy @dajoRH