Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automate: test_reports_generate_custom_conditional_filter_report #9866

Merged
merged 2 commits into from
Jan 27, 2020

Conversation

valaparthvi
Copy link
Contributor

Purpose or Intent

  • Adding tests
    1. Automate: test_reports_generate_custom_conditional_filter_report and remove manual test.

PRT Run

{{ pytest: cfme/tests/intelligence/reports/test_reports.py -k "test_reports_generate_custom_conditional_filter_report" -vvv }}

@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label Jan 23, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jan 24, 2020

I detected some fixture changes in commit 0e02a53

The local fixture edit_service_name is used in the following files:

  • cfme/tests/intelligence/reports/test_reports.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [WIPTEST] Automate: test_reports_generate_custom_conditional_filter_report [RFR] Automate: test_reports_generate_custom_conditional_filter_report Jan 24, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this PR 👍

@john-dupuy john-dupuy changed the title [RFR] Automate: test_reports_generate_custom_conditional_filter_report [1LP][RFR] Automate: test_reports_generate_custom_conditional_filter_report Jan 24, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice scenario 👍

@@ -187,6 +189,15 @@ def setup_vm(configure_fleecing, appliance, provider):

vm.cleanup_on_provider()


@pytest.fixture
def edit_service_name(service_vm):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I would make this an part of test only

@digitronik digitronik self-assigned this Jan 27, 2020
@digitronik digitronik merged commit 783baf2 into ManageIQ:master Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants