This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Add new ProviderCompareHostsView and replace with CompareHostsView in… #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test_compare_hosts_from_provider_allhosts
prichard77
changed the title
|
The 5.11 PRT run passed, but the run is still marked as running. You can see the passing results in the report and artifacts in Ostriz. |
prichard77
changed the title
valaparthvi
approved these changes
Jan 24, 2020
valaparthvi
changed the title
|
Moving this to 1LP, changes look good. 511 run failed with an error, but the test cases have passed. |
digitronik
approved these changes
Jan 27, 2020
| @@ -464,7 +465,7 @@ def test_compare_hosts_from_provider_allhosts(appliance, setup_provider_min_host | |||
| h.ensure_checked() | |||
| hosts_view.toolbar.configuration.item_select('Compare Selected items', | |||
| handle_alert=True) | |||
| compare_hosts_view = provider.create_view(HostsCompareView) | |||
| compare_hosts_view = provider.create_view(ProviderHostsCompareView) | |||
There was a problem hiding this comment.
optional: I would register one navigation destination against provider.
digitronik
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test_compare_hosts_from_provider_allhosts
Purpose or Intent
PRT Run
{{ pytest: cfme/tests/infrastructure/test_host.py::test_compare_hosts_from_provider_allhosts }}