Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fixing tagging test and ignoring deffered bz test for streams 5.10,5.11 #9860

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

kedark3
Copy link
Contributor

@kedark3 kedark3 commented Jan 21, 2020

Purpose or Intent

  • Fixing VMware tests.

PRT Run

{{pytest: cfme/tests/infrastructure/test_vmware_provider.py -k "test_vmware_reconfigure_vm_controller_type or test_vmware_vds_ui_tagging " -v}}

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment about using skip rather than ignore_stream. Just so we can pass additional context

@@ -137,6 +137,7 @@ def test_vmware_vds_ui_display(soft_assert, appliance, provider):


@pytest.mark.tier(1)
@pytest.mark.ignore_stream("5.10", "5.11")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just skip with a small explanation as to why we are skipping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I did this as @mshriver suggested in his email to do so.

@dajoRH dajoRH added the lint-ok label Jan 21, 2020
@john-dupuy john-dupuy changed the title [RFR] Fixing tagging test and ignoring deffered bz test for streams 5.10,5.11 [1LP][RFR] Fixing tagging test and ignoring deffered bz test for streams 5.10,5.11 Jan 22, 2020
@jawatts jawatts self-assigned this Jan 23, 2020
@jawatts jawatts merged commit 25924b6 into ManageIQ:master Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants