-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] CLI - Testing evm stop command #9858
[1LP][RFR] CLI - Testing evm stop command #9858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
command_set = ("ap", RETURN, "16", TimedCommand("Y", 60)) | ||
appliance.appliance_console.run_commands(command_set, timeout=30, output=True) | ||
wait_for(lambda: appliance.is_web_ui_running(), delay=10, timeout=300, fail_condition=True, | ||
message='Waiting to stop EVM service') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgaikwad I think we should extend this test a bit more. I see here:
That we test turning on evmserverd via the appliance_console. But I don't see a test that is turning both on and off the evmserverd via the appliance console. Thoughts on adding that in here? Should be fairly easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jawatts , Thank you for comment.
There had steps in one test case(#9814) that were doing the same which you suggested but test case name was different so we changed test case steps accordingly to testcase name.
Now here I think instead of changing the purpose of the current test case we can add a new testcase in Polarion that can perform stop and start EVM server via appliance_console separately.
What is your opinion?
till now I incorporated remaining your review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we should extend the test here a bit more.
appliance = temp_appliance_preconfig_funcscope | ||
command_set = ("ap", RETURN, "16", TimedCommand("Y", 60)) | ||
appliance.appliance_console.run_commands(command_set, timeout=30, output=True) | ||
wait_for(lambda: appliance.is_web_ui_running(), delay=10, timeout=300, fail_condition=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not check appliance.evmserverd.running
instead?
This reverts commit 5015a4a3998f50f68e87d581e4953d86b5ead811.
cdc225c
to
4092f52
Compare
Purpose or Intent
adding_test Testing EVM service stop command and verification
PRT Run
{{pytest: ./cfme/tests/cli/test_appliance_console.py::test_appliance_console_evm_stop -v}}