Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] CLI - Testing evm stop command #9858

Merged
merged 5 commits into from
Jan 28, 2020

Conversation

dgaikwad
Copy link
Contributor

Purpose or Intent

adding_test Testing EVM service stop command and verification

PRT Run

{{pytest: ./cfme/tests/cli/test_appliance_console.py::test_appliance_console_evm_stop -v}}

@dgaikwad dgaikwad changed the title [WIPTEST] CLI - Testing evm stop command [RFR] CLI - Testing evm stop command Jan 21, 2020
@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Jan 22, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] CLI - Testing evm stop command [1LP][RFR] CLI - Testing evm stop command Jan 22, 2020
command_set = ("ap", RETURN, "16", TimedCommand("Y", 60))
appliance.appliance_console.run_commands(command_set, timeout=30, output=True)
wait_for(lambda: appliance.is_web_ui_running(), delay=10, timeout=300, fail_condition=True,
message='Waiting to stop EVM service')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgaikwad I think we should extend this test a bit more. I see here:

https://github.com/ManageIQ/integration_tests/blob/master/cfme/tests/cli/test_appliance_console.py#L855

That we test turning on evmserverd via the appliance_console. But I don't see a test that is turning both on and off the evmserverd via the appliance console. Thoughts on adding that in here? Should be fairly easy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jawatts , Thank you for comment.
There had steps in one test case(#9814) that were doing the same which you suggested but test case name was different so we changed test case steps accordingly to testcase name.
Now here I think instead of changing the purpose of the current test case we can add a new testcase in Polarion that can perform stop and start EVM server via appliance_console separately.
What is your opinion?
till now I incorporated remaining your review comments.

Copy link
Contributor

@jawatts jawatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should extend the test here a bit more.

appliance = temp_appliance_preconfig_funcscope
command_set = ("ap", RETURN, "16", TimedCommand("Y", 60))
appliance.appliance_console.run_commands(command_set, timeout=30, output=True)
wait_for(lambda: appliance.is_web_ui_running(), delay=10, timeout=300, fail_condition=True,
Copy link
Contributor

@jawatts jawatts Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not check appliance.evmserverd.running instead?

@jawatts jawatts changed the title [1LP][RFR] CLI - Testing evm stop command [1LP][WIPTEST] CLI - Testing evm stop command Jan 23, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_evm_stop branch from cdc225c to 4092f52 Compare January 24, 2020 07:56
@dgaikwad dgaikwad changed the title [1LP][WIPTEST] CLI - Testing evm stop command [1LP][RFR] CLI - Testing evm stop command Jan 24, 2020
@dgaikwad dgaikwad requested a review from jawatts January 24, 2020 10:41
@mshriver mshriver self-assigned this Jan 28, 2020
@mshriver mshriver merged commit 0b26bde into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants