Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix test #9852

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jan 17, 2020

Purpose or Intent

  • Fixing
    1. test_each_page
    2. test_provision_emails
  • Updating tests
    1. Removing parametrization from test_report_filter_content
    2. Add "manualonly" tag to `test_pdf_provider_summary"

PRT Run

{{ pytest: cfme/tests/test_ui.py cfme/tests/infrastructure/test_provisioning_rest.py::test_provision_emails -sqvvv --long-running }}

@dajoRH
Copy link
Contributor

dajoRH commented Jan 24, 2020

I detected some fixture changes in commit f6821d7c3e6ea2554b160b21a6d04107312d7445

The global fixture smtp_test is used in the following files:

  • cfme/tests/automate/test_method.py
    • test_send_email_method
  • cfme/tests/cloud_infra_common/test_provisioning.py
    • test_provision_approval
  • cfme/tests/configure/test_email.py
    • test_send_test_email
  • cfme/tests/control/test_alerts.py
    • test_alert_rtp
    • test_alert_hardware_reconfigured
  • cfme/tests/infrastructure/test_host_provisioning.py
  • cfme/tests/infrastructure/test_provisioning_rest.py
    • test_provision_emails
  • cfme/tests/intelligence/reports/test_reports.py
  • cfme/tests/intelligence/reports/test_reports_schedules.py
    • test_reports_create_schedule_send_report

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi
Copy link
Contributor Author

test_provision_emails fails on PRT because of less number of open ports on PRT containers, but it passes locally, hence moving to RFR.

@valaparthvi valaparthvi changed the title [WIPTEST] Fix test [RFR] Fix test Jan 27, 2020
Fix test_provision_emails

Fix failing smtp_test setup

Remove extra parametrization

Stop firewall
@john-dupuy john-dupuy changed the title [RFR] Fix test [1LP][RFR] Fix test Jan 28, 2020
@john-dupuy
Copy link
Contributor

Based on comment about closed ports on PRT, LGTM 👍

@mshriver mshriver self-assigned this Jan 28, 2020
@mshriver mshriver merged commit 244c8d6 into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants