-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][WIPTEST] Fix test_cloud_init_provisioning for openstack-13 #9849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this PR @JaryN
@@ -95,6 +96,8 @@ def test_provision_cloud_init(appliance, request, setup_provider, provider, prov | |||
floating_ip = mgmt_system.get_first_floating_ip(pool=ip_pool) | |||
provider.refresh_provider_relationships() | |||
inst_args['environment'] = {'public_ip_address': floating_ip} | |||
inst_arg_props = inst_args.setdefault('properties', {}) | |||
inst_arg_props['instance_type'] = partial_match(provisioning['ci-flavor-name']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is partial_match
necessary here? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is. Other provisioning code uses this partial_match. I tried without and it didn't work. I didn't study the problem well, but I think on the prov page, the option includes the flavor details (the VM memory, cpus and stuff), not just the name of the flavor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Failing Travis, please address
-
The yaml structure already contains the desired flavor name under
provisioning.instance_type2
- why not use that key here?
The image with cloud-init needs a bigger flavor than the one which was getting selected so this patch adds using a ci-flavor-name to specifying which flavor to use.
Done. I don'T know how did I miss the pre-commit doing the imports reordering stuff.
That one is used with this image:
while the |
Merged yaml change and restarted PRT. |
PRT failure unrelated to the changes here for provisioning flavor. |
cfme/tests/cloud_infra_common/test_cloud_init_provisioning.py/test_provision_cloud_init_payload[rhevm-4.3] fails because of lack of IPv6 in our PRT openshift I don't know why are the other tests failing. |
The image with cloud-init needs a bigger flavor than the one which was
getting selected so this patch adds using a ci-flavor-name to specifying
which flavor to use.
This needs yamls PR 885