This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test case looks good, just one required comment.
Comment on lines
247
to
252
assignee: sshveta | ||
casecomponent: V2V | ||
testtype: functional | ||
initialEstimate: 1/8h | ||
startsin: 5.9 | ||
tags: V2V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be indented
john-dupuy
changed the title
[RFR]Add migration plan via API
[1LP][WIPTEST]Add migration plan via API
Jan 16, 2020
sshveta
changed the title
[1LP][WIPTEST]Add migration plan via API
[1LP][RFR]Add migration plan via API
Jan 16, 2020
mshriver
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - but the PRT run 227 is a false positive.
Please add a pytest command to the PR description, specifying v2v_group providers.
mshriver
changed the title
[1LP][RFR]Add migration plan via API
[1LP][WIPTEST]Add migration plan via API
Jan 16, 2020
sshveta
changed the title
[1LP][WIPTEST]Add migration plan via API
[1LP][RFR]Add migration plan via API
Jan 17, 2020
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* Add migration plan via API * Add migration plan via API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ pytest: cfme/tests/v2v/test_rest_migrations.py --use-provider rhv43 --use-provider vsphere67-ims --provider-limit 2 -vvvv --long-running -k test_rest_plan_create }}
Test to create migration plan via API