-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Automating copy catalog item with tags #9844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Kindly wait for merge until it can be tested and passes in PRT. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Test case @niyazRedhat .
One comment
@pytest.mark.ignore_stream('5.10') | ||
@pytest.mark.meta(blockers=[BZ(1740399, forced_streams=['5.11'])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add automates please
@pytest.mark.meta(blockers=[BZ(1740399, forced_streams=["5.11"])], automates=[1740399])
422ed51
to
8ddba0b
Compare
The BZ is post State for the last 3 month I think we shouldn't wait for BZ to be verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small question, other than that LGTM
new_cat_item = generic_catalog_item.copy() | ||
request.addfinalizer(new_cat_item.delete_if_exists) | ||
|
||
assert any([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: shouldn't this be all
rather than any
?
8ddba0b
to
7735626
Compare
The test is skipped as it marked with a BZ. |
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_catalog_item.py::test_copy_catalog_item_with_tags }}
No PRT run, the BZ is still in Post state. I have tested locally with ipdb.