Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automating copy catalog item with tags #9844

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

niyazRedhat
Copy link
Contributor

@niyazRedhat niyazRedhat commented Jan 14, 2020

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_catalog_item.py::test_copy_catalog_item_with_tags }}

No PRT run, the BZ is still in Post state. I have tested locally with ipdb.

@niyazRedhat niyazRedhat changed the title [WIPTEST] Automating copy catalog item with tags [RFR] Automating copy catalog item with tags Jan 14, 2020
Copy link
Contributor

@kedark3 kedark3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Kindly wait for merge until it can be tested and passes in PRT. 🎉

Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Test case @niyazRedhat .
One comment

@pytest.mark.ignore_stream('5.10')
@pytest.mark.meta(blockers=[BZ(1740399, forced_streams=['5.11'])])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add automates please

@pytest.mark.meta(blockers=[BZ(1740399, forced_streams=["5.11"])], automates=[1740399])

@niyazRedhat
Copy link
Contributor Author

The BZ is post State for the last 3 month I think we shouldn't wait for BZ to be verified.

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small question, other than that LGTM

new_cat_item = generic_catalog_item.copy()
request.addfinalizer(new_cat_item.delete_if_exists)

assert any([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: shouldn't this be all rather than any?

@john-dupuy john-dupuy changed the title [RFR] Automating copy catalog item with tags [WIPTEST] Automating copy catalog item with tags Jan 16, 2020
@niyazRedhat niyazRedhat changed the title [WIPTEST] Automating copy catalog item with tags [RFR] Automating copy catalog item with tags Jan 22, 2020
@john-dupuy john-dupuy added the test-automation To be applied on PR's which are automating existing manual cases label Jan 22, 2020
@sshveta sshveta changed the title [RFR] Automating copy catalog item with tags [1LP][RFR] Automating copy catalog item with tags Jan 22, 2020
@sshveta
Copy link
Contributor

sshveta commented Jan 22, 2020

The test is skipped as it marked with a BZ.
Some other unrelated test failed from the file.
@niyazRedhat : You can run individual test changed by providing ' -k' in pytest run command

@mshriver mshriver merged commit fe9ebb3 into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants