This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Use appliance provisioning fixtures for distributed and replicated appliance testing #9829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appliance testing.
tpapaioa
changed the title
|
I detected some fixture changes in commit f00a1e6 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
tpapaioa
changed the title
john-dupuy
approved these changes
Jan 16, 2020
| @@ -494,6 +494,8 @@ def configure(self, log_callback=None, **kwargs): | |||
| self.db.create_db_lvm() | |||
| if on_openstack: | |||
| self.set_resolvable_hostname(log_callback=log_callback) | |||
| if db_address: | |||
| self.db_host = db_address | |||
There was a problem hiding this comment.
Since you're now using db_address can you also update L441
There was a problem hiding this comment.
Agreed - I'd like to see a followup doing two things:
- Update the docblock above
- Improve the
db_hostandself.db.addresssetup, so that its not so circular, and operates as a property that isn't self referential.
john-dupuy
changed the title
mshriver
reviewed
Jan 16, 2020
mshriver
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test_appliance_replication.py to provision unconfigured appliances using sprout fixtures.
fixes #3784
Distributed tests don't use random names
#3784
The function-scoped fixture temp_appliances_unconfig_funcscope_rhevm is used to return a pair of unconfigured appliances. Using the 'rhevm' provider type ensures that the two appliances can reach each other's IP address, unlike with, e.g., openstack vm's.
I've also removed the test_appliance_replicate_sync_role_change and test_appliance_replicate_sync_role_change_with_backlog tests, which are no longer relevant (they test the database_synchronization server role, which was removed in CFME 5.7).
{{ pytest: cfme/tests/distributed/test_appliance_replication.py --long-running }}