Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() #9822

Merged
merged 1 commit into from
Jan 9, 2020
Merged

[1LP][RFR] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() #9822

merged 1 commit into from
Jan 9, 2020

Conversation

prichard77
Copy link
Contributor

@prichard77 prichard77 commented Jan 9, 2020 •
edited
Loading

Purpose or Intent

  • Updating tests test_infra_compare_view and test_cloud_compare_view to use slice kwarg in entities.get_all() call instead of the inline slice of the returned values. Since I was testing I also updated these tests to use ensure_checked().

@prichard77
Copy link
Contributor Author

This PR only contains updates to tests and I have executed these to verify the changes.

@prichard77 prichard77 changed the title [WIPTEST] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() [RFR] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() Jan 9, 2020
@dajoRH dajoRH added the lint-ok label Jan 9, 2020
@prichard77
Copy link
Contributor Author

The test failing PRT is test_infra_default_view. It is not one that this PR updated. I'll look into the failure but it shouldn't hold up review.

@prichard77
Copy link
Contributor Author

Retest passed.

john-dupuy
john-dupuy approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 👍

@john-dupuy john-dupuy changed the title [RFR] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() [1LP][RFR] Replace inline slice in entity.get_all() with slice kwarg and use ensure_checked() Jan 9, 2020
@jawatts jawatts merged commit 7f352bf into ManageIQ:master Jan 9, 2020
@prichard77 prichard77 deleted the replaceInlineSliceGetAll branch March 10, 2020 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jawatts jawatts jawatts approved these changes

@john-dupuy john-dupuy john-dupuy approved these changes

Assignees
No one assigned
Labels
enhancement fix-test lint-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prichard77 @jawatts @john-dupuy @dajoRH