Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automated test regions_up_to_date for EC2Provider #9819

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[1LP][RFR] Automated test regions_up_to_date for EC2Provider #9819

merged 1 commit into from
Feb 14, 2020

Conversation

mmojzis
Copy link
Contributor

@mmojzis mmojzis commented Jan 8, 2020 •
edited
Loading

Added automated test regions_up_to_date for EC2Provider
{{ pytest: -k "test_regions_up_to_date.py" -v }}

@mmojzis mmojzis changed the title [WIPTEST]Automated test regions_up_to_date for EC2Provider [RFR]Automated test regions_up_to_date for EC2Provider Jan 8, 2020
@dajoRH dajoRH removed the WIP-testing label Jan 8, 2020
@john-dupuy john-dupuy added the test-automation To be applied on PR's which are automating existing manual cases label Jan 10, 2020
john-dupuy
john-dupuy suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion so that you can avoid the for loop and some suggested variable names. Thanks for this PR 👍

@john-dupuy john-dupuy changed the title [RFR]Automated test regions_up_to_date for EC2Provider [WIPTEST] Automated test regions_up_to_date for EC2Provider Jan 10, 2020
@mmojzis mmojzis force-pushed the test_regions_up_to_date branch from 646b2bc to e189f90 Compare January 14, 2020 12:11
@dajoRH dajoRH added needs-lint and removed lint-ok labels Jan 14, 2020
@mmojzis mmojzis force-pushed the test_regions_up_to_date branch from e189f90 to 2e4c9aa Compare January 14, 2020 12:17
@dajoRH dajoRH added lint-ok and removed needs-lint labels Jan 14, 2020
@mmojzis mmojzis changed the title [WIPTEST] Automated test regions_up_to_date for EC2Provider [RFR] Automated test regions_up_to_date for EC2Provider Jan 29, 2020
@john-dupuy john-dupuy changed the title [RFR] Automated test regions_up_to_date for EC2Provider [WIPTEST] Automated test regions_up_to_date for EC2Provider Jan 30, 2020
@mmojzis mmojzis force-pushed the test_regions_up_to_date branch 2 times, most recently from 4e5addf to 91924b6 Compare February 11, 2020 14:31
@mmojzis mmojzis changed the title [WIPTEST] Automated test regions_up_to_date for EC2Provider [RFR] Automated test regions_up_to_date for EC2Provider Feb 11, 2020
john-dupuy
john-dupuy approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 👍

@john-dupuy john-dupuy changed the title [RFR] Automated test regions_up_to_date for EC2Provider [1LP][RFR] Automated test regions_up_to_date for EC2Provider Feb 14, 2020
@mshriver mshriver self-assigned this Feb 14, 2020
@mshriver mshriver merged commit 1ae14a9 into ManageIQ:master Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mshriver mshriver mshriver approved these changes

@john-dupuy john-dupuy john-dupuy approved these changes

Assignees

@mshriver mshriver

Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmojzis @mshriver @john-dupuy @dajoRH