Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Adding dynamic service dialog test #9817

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

niyazRedhat
Copy link
Contributor

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_dynamic_dialogs --long-running }}

@niyazRedhat niyazRedhat changed the title [WIPTEST] Adding dynamic service dialog test [RFR] Adding dynamic service dialog test Jan 8, 2020
@dajoRH dajoRH removed the WIP-testing label Jan 8, 2020
@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Jan 8, 2020
Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Niyaz , just add a comment about the hardcoded fields coming from dialog.

view.fields("dialog_hostname_master_appliance").read() == appliance.hostname

# Checkbox must be checked for database field
assert view.fields("param_database").checkbox.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that fields like 'limit', 'param_vm_name', 'param_database' and 'dialog_hostname_master_appliance' are coming from imported dialog.

@sshveta sshveta changed the title [RFR] Adding dynamic service dialog test [1LP][WIPTEST] Adding dynamic service dialog test Jan 8, 2020
@niyazRedhat niyazRedhat changed the title [1LP][WIPTEST] Adding dynamic service dialog test [1LP][RFR] Adding dynamic service dialog test Jan 16, 2020
@mshriver mshriver self-assigned this Jan 16, 2020
@mshriver mshriver merged commit 77efe18 into ManageIQ:master Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants