[1LP][RFR] Replace usage of entity.check() with entity.ensure_checked. Part 2. #9816
Conversation
| @@ -293,7 +293,7 @@ def select_entity_rows(self, physical_servers): | |||
| view = navigate_to(self, 'All') | |||
|
|
|||
| for physical_server in physical_servers: | |||
| view.entities.get_entity(name=physical_server.name, surf_pages=True).check() | |||
| view.entities.get_entity(name=physical_server.name, surf_pages=True).ensure_checked() | |||
There was a problem hiding this comment.
added to PRT to cover this. cfme/tests/physical_infrastructure/ui/test_physical_server_list_buttons.py::test_manage_button
| @@ -1128,5 +1128,5 @@ def remove_all_pxe_servers(): | |||
| view = navigate_to(PXEServer, 'All') | |||
| if view.entities.is_displayed: | |||
| for entity in view.entities.rows(): | |||
| entity[0].check() | |||
| entity[0].ensure_checked() | |||
There was a problem hiding this comment.
Added tp PRT to cover this. cfme/tests/physical_infrastructure/ui/test_physical_server_list_buttons.py::test_manage_button
I was unable to get the test run to hit the updated code when running locally, but am hoping PRT might catch it. There were no pxe servers for me to delete when running locally.
| @@ -476,7 +476,7 @@ def check_hosts(self, hosts): | |||
|
|
|||
| for host in hosts: | |||
| try: | |||
| view.entities.get_entity(name=host.name, surf_pages=True).check() | |||
| view.entities.get_entity(name=host.name, surf_pages=True).ensure_checked() | |||
There was a problem hiding this comment.
Added tp PRT to cover this. cfme/tests/infrastructure/test_host.py::test_infrastructure_hosts_navigation_after_download_from_compare
| @@ -413,7 +413,7 @@ def test_no_template_power_control(provider, soft_assert): | |||
| # Check the power button with checking the quadicon | |||
| view = navigate_to(selected_template, 'AllForProvider', use_resetter=False) | |||
| entity = view.entities.get_entity(name=selected_template.name, surf_pages=True) | |||
| entity.check() | |||
| entity.ensure_checked() | |||
There was a problem hiding this comment.
added to PRT to cover this. cfme/tests/infrastructure/test_vm_power_control.py::test_no_template_power_control
cfme/tests/infrastructure/test_vm_power_control.py::test_retire_vm_with_vm_user_role
|
When I run this locally, I get 16 items collected? I am not sure why PRT keeps going invalid. |
|
Rerunning PRT again. 5.11 passed last time, but 5.10 is still hanging because of an issue. Marking RFR to get the process started. |
prichard77
changed the title
john-dupuy
changed the title
…. Part 2. (ManageIQ#9816) * Replace check() with ensure_checked() in PhysicalRackCollection * Replace check() with ensure_checked() in physical files * Replace check() with ensure_checked() in another group of files
Purpose or Intent
PRT Run
{{ pytest: --use-provider rhv42 --use-provider rhos13 --long-running cfme/tests/physical_infrastructure/ui/test_physical_server_list_buttons.py::test_manage_button cfme/tests/infrastructure/test_pxe.py::test_pxe_server_crud cfme/tests/infrastructure/test_host.py::test_infrastructure_hosts_navigation_after_download_from_compare cfme/tests/infrastructure/test_vm_power_control.py::test_no_template_power_control cfme/tests/infrastructure/test_vm_power_control.py::test_retire_vm_with_vm_user_role }}