This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] NewTest::Test Shutdown Appliance #9809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaikwad
force-pushed
the
test_appliance_console_shutdown
branch
2 times, most recently
from
f97fd08 to
4c4febe
Compare
dgaikwad
changed the title
valaparthvi
reviewed
Jan 2, 2020
valaparthvi
added
the
test-automation
dgaikwad
force-pushed
the
test_appliance_console_shutdown
branch
from
4c4febe to
26ad049
Compare
valaparthvi
approved these changes
Jan 2, 2020
valaparthvi
changed the title
dgaikwad
force-pushed
the
test_appliance_console_shutdown
branch
from
26ad049 to
75c52d8
Compare
digitronik
reviewed
Jan 2, 2020
There was a problem hiding this comment.
Nice changes 👍
@dgaikwad just about logger string formatting else LGTM
| appliance = temp_appliance_preconfig_modscope | ||
| command_set = ("ap", RETURN, "19", "Y") | ||
| appliance.appliance_console.run_commands(command_set, timeout=40) | ||
| wait_for(lambda: appliance.ssh_client.connected, |
cfme/utils/appliance/console.py
Outdated
| @@ -44,16 +45,22 @@ def run_commands(self, commands, autoreturn=True, timeout=10, channel=None): | |||
| cmd, timeout = command | |||
| channel.settimeout(timeout) | |||
| cmd = "{}\n".format(cmd) if autoreturn else "{}".format(cmd) | |||
| logger.info(f"Executing sub-command:{cmd}") | |||
There was a problem hiding this comment.
We are fallowing logger default formatting. I would try to avoid f-string.
dgaikwad
force-pushed
the
test_appliance_console_shutdown
branch
from
75c52d8 to
e69d963
Compare
digitronik
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: ./cfme/tests/cli/test_appliance_console.py::test_appliance_console_shutdown --long-running -v}}