Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] NewTest:: testing network configuration using negative input #9807

Merged
merged 2 commits into from
Jan 6, 2020
Merged

[1LP][RFR] NewTest:: testing network configuration using negative input #9807

merged 2 commits into from
Jan 6, 2020

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Dec 31, 2019 •
edited
Loading

Purpose or Intent

PRT Run

  • Testing network configuration using negative input
    Testing below options:
  1. Set DHCP Network Configuration
  2. Test Network Configuration
  3. Set Hostname

{{pytest: cfme/tests/cli/test_appliance_console.py::test_appliance_console_network_conf_negative --long-running -v}}

@dgaikwad dgaikwad changed the title NewTest:: setting up ips using invalid data [WIPTEST] NewTest:: setting up ips using invalid data Dec 31, 2019
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch from 9719ace to f23b283 Compare December 31, 2019 09:35
@dgaikwad dgaikwad changed the title [WIPTEST] NewTest:: setting up ips using invalid data [RFR] NewTest:: setting up ips using invalid data Dec 31, 2019
ganeshhubale
ganeshhubale approved these changes Dec 31, 2019
View reviewed changes
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Show resolved Hide resolved
@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Dec 31, 2019
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch 4 times, most recently from ce5be6b to f6f5a4d Compare December 31, 2019 13:04
@ganeshhubale ganeshhubale changed the title [RFR] NewTest:: setting up ips using invalid data [1LP][RFR] NewTest:: setting up ips using invalid data Jan 1, 2020
@dgaikwad dgaikwad changed the title [1LP][RFR] NewTest:: setting up ips using invalid data [1LP][RFR] NewTest:: testing network configuration using negative input Jan 2, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch from c45df51 to 7f7d3d8 Compare January 2, 2020 09:57
digitronik
digitronik suggested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Some comment and questions please have a glance.

cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
@digitronik digitronik changed the title [1LP][RFR] NewTest:: testing network configuration using negative input [1LP][WIP] NewTest:: testing network configuration using negative input Jan 2, 2020
@dajoRH dajoRH added the WIP label Jan 2, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch from 7f7d3d8 to 38e2bbf Compare January 2, 2020 12:57
@dgaikwad
Copy link
Contributor Author

dgaikwad commented Jan 2, 2020

Following action performed after cove review:

  • Removed parseIPV6() and parseIPV4() functions, this function will be implemented as you suggested and will use same where we need.
  • Improved formatting
  • updated logic where I was storing "ap" command's output in the text file

@dgaikwad dgaikwad changed the title [1LP][WIP] NewTest:: testing network configuration using negative input [1LP][RFR] NewTest:: testing network configuration using negative input Jan 2, 2020
@dajoRH dajoRH removed the WIP label Jan 2, 2020
@dajoRH dajoRH changed the title [1LP][RFR] NewTest:: testing network configuration using negative input [1LP][WIP] NewTest:: testing network configuration using negative input Jan 3, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch from 38e2bbf to b4b71b3 Compare January 3, 2020 07:19
@dajoRH dajoRH added WIP and removed needs-rebase labels Jan 3, 2020
@dgaikwad dgaikwad changed the title [1LP][WIP] NewTest:: testing network configuration using negative input [1LP][WIPTEST] NewTest:: testing network configuration using negative input Jan 3, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Jan 3, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_network_conf_negative branch from b4b71b3 to b91d397 Compare January 3, 2020 13:02
@dgaikwad dgaikwad changed the title [1LP][WIPTEST] NewTest:: testing network configuration using negative input [1LP][RFR] NewTest:: testing network configuration using negative input Jan 6, 2020
@dajoRH dajoRH removed the WIP-testing label Jan 6, 2020
@digitronik digitronik merged commit 67b3e82 into ManageIQ:master Jan 6, 2020
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
@spusateri
[1LP][RFR] NewTest:: testing network configuration using negative inp…
87d9ee6 
…ut (ManageIQ#9807)

* NewTest:: test to set invalid ips

* Updating testcase scenario
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshhubale ganeshhubale ganeshhubale approved these changes

@digitronik digitronik digitronik approved these changes

Assignees
No one assigned
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgaikwad @digitronik @ganeshhubale @dajoRH