This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] clean up version picking and time.sleeps in ssui service module #9793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
commented
Dec 19, 2019
| @@ -206,10 +190,10 @@ def update(self, updates): | |||
| view.fill_with(updates, on_change=view.save_button, no_change=view.cancel_button) | |||
| view.flash.assert_no_error() | |||
| view = self.create_view(DetailsMyServiceView, override=updates) | |||
| # TODO - remove sleep when BZ 1518954 is fixed | |||
There was a problem hiding this comment.
This BZ was not fixed (NOTABUG/WONTFIX)
izapolsk
changed the title
izapolsk
approved these changes
Dec 20, 2019
| message_present, _ = wait_for(view.notification.assert_message, | ||
| func_args=[f'{self.name} was edited.'], | ||
| timeout=10) | ||
| assert message_present |
There was a problem hiding this comment.
this is redundant since you alrady check this in wait_for and it will fail with exception otherwise.
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version pick dictionaries, 10s static sleeps