This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] New Test:: Testing start EVM command #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaikwad
changed the title
dgaikwad
changed the title
ganeshhubale
added
the
test-automation
ganeshhubale
suggested changes
Dec 19, 2019
| wait_for(lambda: appliance.is_web_ui_running(), delay=30, num_sec=10) | ||
| logged_in_page = appliance.server.login() | ||
| assert logged_in_page.is_displayed, "UI is not working after starting the EVM service." | ||
| logged_in_page.logout() | ||
|
|
There was a problem hiding this comment.
@dgaikwad
If assertion gets failed then this line(logged_in_page.logout()) will not execute. So is it okay if we add this in request.addfinalizer above the assertion. Thus it will act as teardown for this test case.
dgaikwad
force-pushed
the
test_appliance_console_evm_start
branch
2 times, most recently
from
ac529eb
to
8d8de9e
Compare
ganeshhubale
changed the title
dgaikwad
force-pushed
the
test_appliance_console_evm_start
branch
from
8d8de9e
to
31c7713
Compare
ganeshhubale
approved these changes
Dec 23, 2019
dgaikwad
changed the title
ganeshhubale
changed the title
digitronik
reviewed
Dec 24, 2019
| appliance.appliance_console.run_commands(start_evm_command, timeout=300) | ||
| wait_for(lambda: appliance.is_web_ui_running(), delay=30, num_sec=10) | ||
| logged_in_page = appliance.server.login() | ||
| request.addfinalizer(logged_in_page.logout) |
There was a problem hiding this comment.
I would use appliance.server.logout
dgaikwad
force-pushed
the
test_appliance_console_evm_start
branch
from
31c7713
to
9f95aef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run