This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] New Test: test_crud_service_template_with_picture #9774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
force-pushed
the
st_picture
branch
from
78807cb to
4112cf0
Compare
valaparthvi
changed the title
valaparthvi
force-pushed
the
st_picture
branch
from
4112cf0 to
8858582
Compare
ganeshhubale
suggested changes
Dec 17, 2019
| 2. Note the picture md5 by querying `picture` attribute of the service template. | ||
| 3. Edit the service template via REST for a different picture. | ||
| 4. Note the picture md5 by querying `picture` attribute of the service template. | ||
| 3. Compare both the md5 from testStep 2 and 4. |
There was a problem hiding this comment.
It should be 5. Compare both the md5 from testStep 2 and 4. Right?
ganeshhubale
changed the title
valaparthvi
force-pushed
the
st_picture
branch
from
8858582 to
f0ab2f0
Compare
valaparthvi
changed the title
ganeshhubale
approved these changes
Dec 17, 2019
ganeshhubale
changed the title
valaparthvi
force-pushed
the
st_picture
branch
from
f0ab2f0 to
3002e82
Compare
digitronik
suggested changes
Dec 19, 2019
|
|
||
| assert picture_1_md5 != picture_2_md5 | ||
|
|
||
| service_template.action.delete() |
There was a problem hiding this comment.
Q: why we need this deletion? I think it should be taken care by finalizer.
There was a problem hiding this comment.
I could let finalizer do the deletion, but then I thought, since I was already creating and editing the template, I might as well delete it to justify the crud in the test name 😬
There was a problem hiding this comment.
I think best practice is limit test as per test behavior. If deletion will fails means teardown of test will fail not actual steps. I think better to have separate test for crud operation test.
| }, | ||
| "service_type": "atomic", | ||
| "display": True, | ||
| "description": fauxfactory.gen_alpha(start="Description "), |
There was a problem hiding this comment.
Required: fauxfactory default character limit is 10
digitronik
changed the title
valaparthvi
force-pushed
the
st_picture
branch
from
3002e82 to
951d334
Compare
valaparthvi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Adding tests
test_crud_service_template_with_pictureEnhancement
rest_api_entityproperty toDialogentityCatalogentityPRT Run
{{ pytest: cfme/tests/services/test_rest_services.py -k "test_crud_service_template_with_picture" --long-running -vvvv }}