This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automate: test_provider_documentation #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
added
enhancement
test-automation
valaparthvi
force-pushed
the
provider_doc
branch
from
577f41f
to
41e1407
Compare
valaparthvi
changed the title
dajoRH
changed the title
valaparthvi
force-pushed
the
provider_doc
branch
from
41e1407
to
471124d
Compare
valaparthvi
changed the title
valaparthvi
changed the title
valaparthvi
force-pushed
the
provider_doc
branch
3 times, most recently
from
6286181
to
eae5f9a
Compare
|
Please have a look at 5.11 PRT failures. |
ganeshhubale
changed the title
dajoRH
changed the title
valaparthvi
force-pushed
the
provider_doc
branch
from
eae5f9a
to
b14ed27
Compare
valaparthvi
force-pushed
the
provider_doc
branch
from
b14ed27
to
21dafc4
Compare
valaparthvi
changed the title
valaparthvi
changed the title
valaparthvi
requested review from
digitronik
and removed request for
digitronik
sshveta
suggested changes
Jan 21, 2020
|
|
||
| # TODO: Remove this once `ensure_page_safe()` is equipped to handle WebDriverException | ||
| # When a new window opens, URL takes time to load, this will act as a workaround. | ||
| import time |
There was a problem hiding this comment.
Can we wait for something here instead of sleep.
view.wait_for_something() in UI ?
There was a problem hiding this comment.
Nope, I have tried everything I could think of, it's not possible to use wait_for here, time.sleep is the best way right now.
ganeshhubale
approved these changes
Jan 22, 2020
ganeshhubale
changed the title
sshveta
approved these changes
Jan 22, 2020
mshriver
reviewed
Jan 24, 2020
| @@ -567,6 +581,67 @@ def test_infrastructure_provider_left_panel_titles( | |||
| soft_assert(test_view.is_displayed, f"{test_view} not displayed.") | |||
|
|
|||
|
|
|||
| @pytest.mark.tier(1) | |||
| @pytest.mark.ignore_stream("5.10") | |||
There was a problem hiding this comment.
Needs to be ignored on upstream builds as well, since we're using an access.redhat.com URL.
Why only run against CFME 5.11?
mshriver
reviewed
Jan 24, 2020
| initial_count = len(view.browser.window_handles) | ||
| main_window = view.browser.current_window_handle | ||
|
|
||
| href = Text( |
There was a problem hiding this comment.
Consider defining a widget on the Provider view instead of just putting this in the test.
mshriver
approved these changes
Jan 24, 2020
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* Automate: test_provider_documentation * Use temp_appliance_preconfig incase of failures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
test_provider_documentationand remove it's manual test.ConfigManagementCollectionViewandConfigManagementViewviewsis_displayedto work for navigation throughAnsibleTowerProviderandSatelliteProviderclass.data/ui/provider_docs.yamlPRT Run
{{ pytest: cfme/tests/webui/test_general_ui.py -k "test_provider_documentation" -vvv }}