Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automate dynamic dialog execution #9767

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

digitronik
Copy link
Contributor

Purpose or Intent

  • Created customer story based on BZ-1695804
  • Here I don't want to use fixtures for setup :D. Just end-end test

PRT Run

{{pytest: cfme/tests/ssui/test_ssui_myservice.py::test_service_dynamic_dialog_execution --long-running}}

@digitronik digitronik force-pushed the ssui_dialog branch 3 times, most recently from 2e5c324 to c9dc0da Compare December 18, 2019 07:02
@digitronik digitronik changed the title [WIPTEST] Automate dynamic dialog execution [RFR] Automate dynamic dialog execution Dec 18, 2019
@digitronik digitronik added customer-case test-automation To be applied on PR's which are automating existing manual cases labels Dec 18, 2019
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

assert timeit(lambda: navigate_to(service, "Details"), number=1) < 20

# The API call should not takes 20 seconds (sleep time). l.e it should not call automate method.
with LogValidator(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: l.e

Copy link
Contributor

@niyazRedhat niyazRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR.

@ganeshhubale ganeshhubale changed the title [RFR] Automate dynamic dialog execution [1LP][RFR] Automate dynamic dialog execution Dec 19, 2019
@mshriver mshriver self-assigned this Dec 19, 2019
@mshriver mshriver changed the title [1LP][RFR] Automate dynamic dialog execution [1LP][WIPTEST] Automate dynamic dialog execution Dec 19, 2019
@digitronik digitronik changed the title [1LP][WIPTEST] Automate dynamic dialog execution [1LP][RFR] Automate dynamic dialog execution Dec 20, 2019
@digitronik digitronik requested a review from mshriver December 20, 2019 16:04
@digitronik digitronik merged commit 1e1bf2f into ManageIQ:master Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-case lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants