[1LP][RFR] New Test: Testing quota simultaneous #9740

ganeshhubale · 2019-12-09T11:01:27Z

Signed-off-by: Ganesh Hubale [email protected]

Purpose or Intent

Test multiple tenant quotas simultaneously

PRT Run

{{ pytest: cfme/tests/infrastructure/test_tenant_quota.py -k 'test_simultaneous_tenant_quota' --use-template-cache -qsvv --use-provider=rhv43 }}

valaparthvi

Two questions about re-login, and another about using REST to create tenant, group, and users, LGTM otherwise.

valaparthvi · 2019-12-31T04:43:59Z

cfme/tests/infrastructure/test_tenant_quota.py

+        tenant = appliance.collections.tenants.create(
+            name=fauxfactory.gen_alphanumeric(18, start="test_parent_"),
+            description=fauxfactory.gen_alphanumeric(18, start="parent_desc_"),
+            parent=appliance.collections.tenants.get_root_tenant()
+        )


Thoughts on using REST to create tenants?

@valaparthvi

Tenants are very important with respect to QUOTA related test cases. So it is always better to create them via UI. So we can confirm that there is no issue while creating tenants, child tenants or projects and it's child.

Hence I am keeping as it is for this as well as coming test cases of quota.

valaparthvi · 2019-12-31T04:45:37Z

cfme/tests/infrastructure/test_tenant_quota.py

+@pytest.fixture(scope='module')
+def new_project(appliance, new_tenants):
+    """This fixture create project under parent tenant1"""
+    tenant1, tenant2 = new_tenants


If you're not going to use tenant2, you could just do just use _ instead.
tenant1, _ = new_tenants

valaparthvi · 2019-12-31T04:46:04Z

cfme/tests/infrastructure/test_tenant_quota.py

+    field_value = request.param
+    tenant_quota_data = {}
+    for field, value in field_value:
+        tenant_quota_data.update({f"{field}_cb": True, field: value})


Thoughts on using f-string here?

Already used.

valaparthvi · 2019-12-31T04:48:00Z

cfme/tests/infrastructure/test_tenant_quota.py

+        tenant_quota_data.update({f"{field}_cb": True, field: value})
+    new_project.set_quota(**tenant_quota_data)
+    yield
+    appliance.server.login_admin()


Why do you need to login? When you do new_project.set_quota(...), it would automatically login.

cfme/tests/infrastructure/test_tenant_quota.py

valaparthvi · 2019-12-31T04:49:25Z

cfme/tests/infrastructure/test_tenant_quota.py

+@pytest.fixture(scope="module")
+def new_user_project(appliance, new_group_project):
+    """This fixture creates new user which is assigned to new group and project"""
+    user = appliance.collections.users.create(


Thoughts on using REST?

same as above

valaparthvi · 2019-12-31T04:51:38Z

cfme/tests/infrastructure/test_tenant_quota.py

+    """
+    with new_user_project:
+        with appliance.context.use(context):
+            appliance.server.login(new_user_project)


Why do you login again with the new_user_project? As far as I know, when you do with new_user_project it automatically logs in with the new_user_project and performs the actions.

Yeah, I also tried what you are suggesting but this is the user(not having admin rights). Logs in to SSUI portal and order the catalog item. So this needs explicitly login using appliance.server.login()

digitronik

Nice PR. Some comments please have a glance.

digitronik · 2020-01-02T06:37:38Z

cfme/configure/access_control/__init__.py

-                raise RBACOperationBlocked("Configuration action '{}' is not enabled".format(
-                    edit_group_txt))
+        if not view.toolbar.configuration.is_enabled:
+            raise RBACOperationBlocked(f"Configuration action 'Edit this Group' is not enabled")


unnecessary use of f string.

digitronik · 2020-01-02T06:48:15Z

cfme/tests/infrastructure/test_tenant_quota.py

+def new_group_project(appliance, new_project):
+    """This fixture creates new group and assigned by new project"""
+    role = appliance.collections.roles.instantiate(name="EvmRole-user_self_service")
+    user_role = role.copy(


we need teardown for copied role ^^

digitronik · 2020-01-02T06:55:27Z

cfme/tests/infrastructure/test_tenant_quota.py

+            service_catalogs.order()
+    # nav to requests page to check quota validation
+    request_description = f'Provisioning Service [{catalog_item.name}] from [{catalog_item.name}]'
+    provision_request = appliance.collections.requests.instantiate(request_description)


I think no need of instantiating provision request. Its already instantiate by order method.

- Testing quota simultaneous Signed-off-by: Ganesh Hubale <[email protected]>

dajoRH · 2020-01-02T08:02:35Z

I detected some fixture changes in commit 1a411f7

The local fixture new_tenants is used in the following files:

cfme/tests/infrastructure/test_tenant_quota.py
- new_project

The local fixture new_project is used in the following files:

cfme/tests/infrastructure/test_tenant_quota.py
- set_project_quota
- new_group_project
- test_simultaneous_tenant_quota

The local fixture set_project_quota is used in the following files:

cfme/tests/infrastructure/test_tenant_quota.py

The local fixture new_group_project is used in the following files:

cfme/tests/infrastructure/test_tenant_quota.py
- new_user_project

The local fixture new_user_project is used in the following files:

cfme/tests/infrastructure/test_tenant_quota.py
- test_simultaneous_tenant_quota

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Dec 9, 2019

dajoRH added lint-ok WIP labels Dec 9, 2019

ganeshhubale changed the title ~~[WIP] New Test: Testing quota simultaneous~~ [WIPTEST] New Test: Testing quota simultaneous Dec 11, 2019

ganeshhubale force-pushed the simult-quota branch from 022a9be to 3c24000 Compare December 11, 2019 13:08

dajoRH added WIP-testing and removed WIP labels Dec 11, 2019

ganeshhubale force-pushed the simult-quota branch 2 times, most recently from 259468c to 0b6b9b5 Compare December 26, 2019 12:16

ganeshhubale changed the title ~~[WIPTEST] New Test: Testing quota simultaneous~~ [RFR] New Test: Testing quota simultaneous Dec 26, 2019

dajoRH removed the WIP-testing label Dec 26, 2019

ganeshhubale requested a review from john-dupuy December 26, 2019 13:00

valaparthvi suggested changes Dec 31, 2019

View reviewed changes

ganeshhubale force-pushed the simult-quota branch from 0b6b9b5 to ff116d6 Compare December 31, 2019 07:24

valaparthvi changed the title ~~[RFR] New Test: Testing quota simultaneous~~ [1LP][RFR] New Test: Testing quota simultaneous Jan 1, 2020

valaparthvi approved these changes Jan 1, 2020

View reviewed changes

digitronik suggested changes Jan 2, 2020

View reviewed changes

digitronik changed the title ~~[1LP][RFR] New Test: Testing quota simultaneous~~ [1LP][WIP] New Test: Testing quota simultaneous Jan 2, 2020

dajoRH added the WIP label Jan 2, 2020

Ganesh Hubale added 2 commits January 2, 2020 13:05

New Test:

95d0862

- Testing quota simultaneous Signed-off-by: Ganesh Hubale <[email protected]>

Updated with requested changes

3351712

ganeshhubale changed the title ~~[1LP][WIP] New Test: Testing quota simultaneous~~ [1LP][WIPTEST] New Test: Testing quota simultaneous Jan 2, 2020

dajoRH added WIP-testing and removed WIP labels Jan 2, 2020

Removed instantiation of provision request

1a411f7

ganeshhubale force-pushed the simult-quota branch from ff116d6 to 1a411f7 Compare January 2, 2020 07:49

ganeshhubale changed the title ~~[1LP][WIPTEST] New Test: Testing quota simultaneous~~ [1LP][RFR] New Test: Testing quota simultaneous Jan 2, 2020

dajoRH removed the WIP-testing label Jan 2, 2020

digitronik approved these changes Jan 2, 2020

View reviewed changes

digitronik merged commit b1d8a8e into ManageIQ:master Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] New Test: Testing quota simultaneous #9740

[1LP][RFR] New Test: Testing quota simultaneous #9740

ganeshhubale commented Dec 9, 2019

valaparthvi left a comment

valaparthvi Dec 31, 2019

ganeshhubale Dec 31, 2019

valaparthvi Dec 31, 2019

valaparthvi Dec 31, 2019

ganeshhubale Dec 31, 2019

valaparthvi Dec 31, 2019

valaparthvi Dec 31, 2019

ganeshhubale Dec 31, 2019

valaparthvi Dec 31, 2019

ganeshhubale Dec 31, 2019

digitronik left a comment

digitronik Jan 2, 2020

digitronik Jan 2, 2020

digitronik Jan 2, 2020

dajoRH commented Jan 2, 2020

[1LP][RFR] New Test: Testing quota simultaneous #9740

[1LP][RFR] New Test: Testing quota simultaneous #9740

Conversation

ganeshhubale commented Dec 9, 2019

Purpose or Intent

PRT Run

valaparthvi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

digitronik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dajoRH commented Jan 2, 2020