This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] Fix test failure #9731
Merged
[RFR] Fix test failure #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
changed the title
valaparthvi
force-pushed
the
fix_config_test
branch
5 times, most recently
from
ff65232 to
18893f5
Compare
|
I detected some fixture changes in commit 18893f5e3ae8c21a05a2e12099065a5186ac02be The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
|
@valaparthvi changes LGTM but these will also be fixed by #9317 |
|
Hey @john-dupuy I see this PR will bring some major changes. But, since the PR is big, I'm assuming it would take some time to get merged, so can we carry on with these fixes for now? |
valaparthvi
force-pushed
the
fix_config_test
branch
from
18893f5 to
eb0fb7e
Compare
valaparthvi
force-pushed
the
fix_config_test
branch
from
eb0fb7e to
b9f0fb4
Compare
|
Hey @john-dupuy I removed the changes related to config_manager, can we take this PR further now? |
izapolsk
approved these changes
Dec 12, 2019
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* Fix webui/test_rest.py * Fix test test_create_picture_with_role
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{ pytest: cfme/tests -k "test_create_picture_with_role or test_delete_advanced_search_filter_from_detail or test_delete_advanced_search_filter_from_collection" -vvv }}