This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] fix slave id representation in logs #9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
changed the title
izapolsk
force-pushed
the
fix_slave_id
branch
from
809639b
to
381d0d0
Compare
john-dupuy
reviewed
Nov 26, 2019
john-dupuy
approved these changes
Nov 26, 2019
john-dupuy
changed the title
jawatts
approved these changes
Nov 26, 2019
mshriver
approved these changes
Nov 26, 2019
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* fix slave id representation in logs * updating requirements to the latest attr lib with repr support * fixed a few places where repr isn't called for some reason
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slave id appears as bytes in logs everywhere. That's a bit annoying.
This PR should make it appear as string in logs.
{ pytest: --long-running --use-template-cache --collect-only --dummy-appliance --num-dummies 10 }