This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Migration throttling fix #9662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedark3
reviewed
Nov 26, 2019
| host_creds = provider.hosts.all() | ||
| hosts_dict = {key.name: [] for key in host_creds} | ||
| if provider.one_of(RHEVMProvider): | ||
| host_creds = [h.name for h in provider.hosts.all()] |
There was a problem hiding this comment.
Can you please elaborate on why the variable is called host_creds when it is storing host_name ?
kedark3
reviewed
Nov 26, 2019
john-dupuy
approved these changes
Dec 2, 2019
john-dupuy
changed the title
sshveta
changed the title
dajoRH
changed the title
sshveta
force-pushed
the
migration_throttling_fix
branch
from
9b6501f
to
856fe98
Compare
sshveta
changed the title
sshveta
changed the title
mshriver
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ pytest: cfme/tests/v2v/test_migration_throttling.py --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 -vvvv --long-running }}
Fixes Throttling test for OSP