This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][WIPTEST] Automated Test Case for BZ 1732442 #9658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawatts
force-pushed
the
bz_1749060_automated_test
branch
from
November 22, 2019 16:08
e39ef96
to
08aeaaf
Compare
jawatts
changed the title
[WIP] Automated Test Case for BZ 1732442
[WIPTEST] Automated Test Case for BZ 1732442
Nov 22, 2019
john-dupuy
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I have some small comments
jawatts
force-pushed
the
bz_1749060_automated_test
branch
2 times, most recently
from
November 22, 2019 19:13
85048f5
to
30695b4
Compare
john-dupuy
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, waiting on PRT to move to 1LP
mshriver
reviewed
Nov 22, 2019
all_db_entries = image_query.all() | ||
|
||
if not all_db_entries: | ||
assert False, "No Entries in the containter_groups DB table" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest.fail
john-dupuy
changed the title
[WIPTEST] Automated Test Case for BZ 1732442
[1LP][WIPTEST] Automated Test Case for BZ 1732442
Nov 22, 2019
I detected some fixture changes in commit 30695b45249da5c1dd609e3849eaaca38d4c1b57 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
jawatts
force-pushed
the
bz_1749060_automated_test
branch
from
November 22, 2019 20:14
30695b4
to
8c2dfe9
Compare
mshriver
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ pytest: cfme/tests/containers/test_container_provider_refresh.py --use-provider ocp-39-hawk }}