Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][WIPTEST] Automated Test Case for BZ 1732442 #9658

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

jawatts
Copy link
Contributor

@jawatts jawatts commented Nov 22, 2019

{{ pytest: cfme/tests/containers/test_container_provider_refresh.py --use-provider ocp-39-hawk }}

@jawatts jawatts changed the title [WIP] Automated Test Case for BZ 1732442 [WIPTEST] Automated Test Case for BZ 1732442 Nov 22, 2019
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some small comments

cfme/tests/containers/test_container_provider_refresh.py Outdated Show resolved Hide resolved
cfme/tests/containers/test_container_provider_refresh.py Outdated Show resolved Hide resolved
cfme/tests/containers/test_container_provider_refresh.py Outdated Show resolved Hide resolved
cfme/tests/containers/test_container_provider_refresh.py Outdated Show resolved Hide resolved
@dajoRH dajoRH added WIP-testing and removed WIP labels Nov 22, 2019
@jawatts jawatts force-pushed the bz_1749060_automated_test branch 2 times, most recently from 85048f5 to 30695b4 Compare November 22, 2019 19:13
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting on PRT to move to 1LP

all_db_entries = image_query.all()

if not all_db_entries:
assert False, "No Entries in the containter_groups DB table"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest.fail

@john-dupuy john-dupuy changed the title [WIPTEST] Automated Test Case for BZ 1732442 [1LP][WIPTEST] Automated Test Case for BZ 1732442 Nov 22, 2019
@dajoRH
Copy link
Contributor

dajoRH commented Nov 22, 2019

I detected some fixture changes in commit 30695b45249da5c1dd609e3849eaaca38d4c1b57

The local fixture setup_temp_appliance_provider is used in the following files:

  • cfme/tests/containers/test_container_provider_refresh.py
    • test_dup_db_entry_refresh

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@mshriver mshriver merged commit 3f9312c into ManageIQ:master Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants