This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] SSUI page provider check tests #9655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitronik
changed the title
ganeshhubale
added
test-automation
ganeshhubale
changed the title
mshriver
reviewed
Nov 22, 2019
| @@ -175,6 +176,11 @@ class MyServiceVMDetailsView(MyServicesView): | |||
| # TODO: This view needs enhancement by FA owner. | |||
| # TimelinesChart Widget not supporting completely need improvements as per SSUI. | |||
|
|
|||
| # I won't found better way than indexing on this Page. | |||
There was a problem hiding this comment.
Too bad, thanks for at least commenting it.
mshriver
reviewed
Nov 22, 2019
| @@ -55,7 +57,7 @@ def service_dialog(appliance, widget_name): | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="function") | |||
| def catalog_item(appliance, service_dialog, catalog): | |||
| def catalog_item_local(appliance, service_dialog, catalog): | |||
There was a problem hiding this comment.
You actually don't need to change the name of the fixture, pytest will resolve the most local one matching the node's scope.
There was a problem hiding this comment.
Actually pytest took local catalog_item fixture instate of catalog_item global fixture; when we call global service_vm.
mshriver
reviewed
Nov 22, 2019
| @@ -5946,3 +5946,17 @@ def messages(self): | |||
| except NoSuchElementException: | |||
| pass | |||
| return result | |||
|
|
|||
|
|
|||
| class SSUICardPFInfoStatus(Widget): | |||
There was a problem hiding this comment.
Consider subclassing widgetastic.widget.GenericLocatorWidget when setting up a widget like this, as it takes care of mapping ROOT to the passed locator.
mshriver
approved these changes
Nov 22, 2019
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* ssui pf card widget and use in vm datails page * automate provider check ssui test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_provider_field_should_display_in_vm_details_page_in_ssui -v}}