[1LP][RFR] Fix restore (and proxy) tests second part #9645
Conversation
jarovo
changed the title
There was a problem hiding this comment.
Awesome PR @JaryN the utility VM is a cool idea. I have some small comments.
cfme/tests/configure/test_proxy.py
Outdated
| with SSHClient( | ||
| hostname=proxy_ip, | ||
| **credentials['proxy_vm']) as ssh_client: | ||
| username='root', |
There was a problem hiding this comment.
I think we should avoid the hardcoded string here. Kind of goes along with my previous comment of having the utility_vm's data folded into it's fixture.
There was a problem hiding this comment.
I started using the injected_user_* here
john-dupuy
changed the title
There was a problem hiding this comment.
I refactored this PR. In the end IIRC I made all the changes required by @john-dupuy in this PR and rebased the followup (and resolving the conflicts)
The message when EC2 cannot be refreshed differs from the other providers.
Co-Authored-By: john-dupuy <[email protected]>
I am putting the code obtaining the metadata to the utility_vm fixture instead.
Backup and restore was failing on PRT because of short timeout.
|
I detected some fixture changes in commit 6d1a2bd The global fixture
The global fixture
The global fixture
The global fixture
The global fixture
The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
jarovo
changed the title
| @@ -0,0 +1,133 @@ | |||
| # -*- coding: utf-8 -*- | |||
| """ The utility_vm is a vm that is meant to serve various services that the | |||
* Add scripts for creating the utility machine template. * use utility_machine for both: proxy and a network share. * Use wait_pingable rather wait_for and find_pingable * Remove dup proxy tests * Fix EC2 proxy invalid test. The message when EC2 cannot be refreshed differs from the other providers. * Fix RHEL8 identifier * Improve error messages in utility-vm Co-Authored-By: john-dupuy <[email protected]> * Don't use random password for utility_vm * remove the network_share fixture I am putting the code obtaining the metadata to the utility_vm fixture instead. * Bump wrapanapi to support initialization parameters. * Use SSHCredential for passing creds from the utility_vm fixture. * Don't use ping to find the IP of services of the utility_vm. * Increase nfs and samba timeouts Backup and restore was failing on PRT because of short timeout. * Increase default timeout for the proxy to get IPs.
Purpose or Intent
{{ py.test: --use-provider 'complete' --use-provider extcloud -v cfme/tests/cli/test_appliance_console_db_restore.py::test_appliance_console_restore_db_nfs cfme/tests/cli/test_appliance_console_db_restore.py::test_appliance_console_restore_db_samba cfme/tests/configure/test_proxy.py }}
Needs:
Test results:
I expect all the test except the
test_appliance_console_restore_db_hato pass.Currently there are skips because the needs are not merged and the
test_appliance_console_restore_db_externalfailed on timeout when restoring the db. IIRC I was increasing the timeout in the #9646 where the same test passes.