This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] Refactoring: delete copypasta in test_embedded_ansible_tags #9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psimovec
force-pushed
the
cleanup_ansible_tags
branch
from
b4eea26 to
8d12fb4
Compare
psimovec
changed the title
psimovec
changed the title
mshriver
reviewed
Nov 19, 2019
psimovec
force-pushed
the
cleanup_ansible_tags
branch
from
8d12fb4 to
83ae674
Compare
|
I detected some fixture changes in commit 83ae674 The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
john-dupuy
added
the
test-cleanup
john-dupuy
approved these changes
Nov 19, 2019
john-dupuy
reviewed
Nov 19, 2019
There was a problem hiding this comment.
Nice work @psimovec! I would like to see a PRT run against this new function however.
mshriver
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_tag_ansible_playbook[details] failed in latest test run, not fixing the test case in this PR