This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] No more session fixtures #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
force-pushed
the
no-more-session-fixtures
branch
from
1783bff to
d78ce6e
Compare
izapolsk
force-pushed
the
no-more-session-fixtures
branch
2 times, most recently
from
ace6908 to
fc49e8e
Compare
izapolsk
changed the title
izapolsk
force-pushed
the
no-more-session-fixtures
branch
from
83ecf60 to
7b07109
Compare
izapolsk
changed the title
izapolsk
force-pushed
the
no-more-session-fixtures
branch
from
85cd96c to
69fb25b
Compare
izapolsk
force-pushed
the
no-more-session-fixtures
branch
from
5fc5269 to
6e715b9
Compare
izapolsk
changed the title
izapolsk
force-pushed
the
no-more-session-fixtures
branch
from
6e715b9 to
308fb1a
Compare
jawatts
reviewed
Nov 20, 2019
| @@ -4,5 +4,5 @@ | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
There was a problem hiding this comment.
is this suppose to be session still?
There was a problem hiding this comment.
yes. I have to get rid of session scoped fixtures which use appliance. the rest can be left as is.
jawatts
changed the title
mshriver
reviewed
Nov 20, 2019
| @@ -4,5 +4,5 @@ | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def cfme_data(request): | |||
| def cfme_data(): | |||
There was a problem hiding this comment.
Wow, I don't think we're actually using this anywhere.
mshriver
reviewed
Nov 20, 2019
| logger.info("Pushed appliance {} on stack (was {} before) ".format( | ||
| obj.hostname, was_before.hostname if was_before else 'empty')) | ||
| logger.info(f"Pushed appliance {obj.hostname} on stack " | ||
| f"(was {was_before.hostname if was_before else 'empty'} before)") |
There was a problem hiding this comment.
Almost breaking your own rules for f-strings ;)
mshriver
approved these changes
Nov 20, 2019
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
there is a plan to implement appliance markers and generate appliances based on those markers. We should get rid of session scoped fixuters using appliance fixture. This PR is one of steps we have to undertake to achieve above. Adding hook registering and calling for the appliance stack, in order to call methods on appliances, whenever they're used for tests. Replaces previous session scoped fixtures that were modifying the appliance at the start of the session.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a plan to implement appliance markers and generate appliances based on those markers.
We should get rid of session scoped fixuters using appliance fixture. This PR is one of steps we have to undertake to achieve above.
based on #9638