Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] separate dialog and datastores #9626

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

digitronik
Copy link
Contributor

@digitronik digitronik commented Nov 15, 2019

Purpose or Intent

  • In FTP server we have separate folders for each entity. mapping as fallow
  entities:
    # Storage path on FTP Server.
    databases: "miq/Databases"
    datastores: "miq/Datastores"
    dialogs: "miq/Dialogs"
    others: "miq/Others"
    reports: "miq/Reports"
  • Copy all dialogs from datastores to dialog for now.

  • As this PR merged; I will remove dialogs l.e. yml files from datastores

  • Always file name can't be a dialog label so added some enhancement in same PR

PRT Run

{{pytest: -sqvv cfme/tests/ -k "test_service_dialog_expression_method or test_update_dynamic_checkbox_field or test_automate_methods_from_dynamic_dialog_should_run_as_per_designed or test_refresh_dynamic_field or test_dynamic_field_on_refresh_button or test_edit_import_dialog or test_upload_blank_file"}}

@digitronik digitronik changed the title [WIP] separate dialog and datastores [WIPTEST] separate dialog and datastores Nov 15, 2019
@dajoRH
Copy link
Contributor

dajoRH commented Nov 15, 2019

I detected some fixture changes in commit 1daa046

The global fixture import_dialog is used in the following files:

  • cfme/tests/automate/test_service_dialog.py
  • cfme/tests/services/test_dialog_element_in_catalog.py
  • cfme/tests/services/test_service_customer_bz.py
    • test_edit_import_dialog

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@digitronik
Copy link
Contributor Author

PRT one test failing due to VM ssh not related to code change

@digitronik digitronik changed the title [WIPTEST] separate dialog and datastores [RFR] separate dialog and datastores Nov 15, 2019
@john-dupuy john-dupuy changed the title [RFR] separate dialog and datastores [1LP][RFR] separate dialog and datastores Nov 15, 2019
@izapolsk izapolsk merged commit 9c72a1d into ManageIQ:master Nov 18, 2019
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
* separate dialog and datastores

* label and description should take from yml only
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants