This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Service retired #9620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitronik
added
enhancement
test-automation
|
PRT tear down failure will fix by #9619 |
digitronik
requested review from
niyazRedhat and
sshveta
and removed request for
niyazRedhat and
sshveta
jarovo
reviewed
Nov 14, 2019
|
|
||
| @request.addfinalizer | ||
| def _clear_retire_request(): | ||
| if retire_request.exists(): |
There was a problem hiding this comment.
I think it this test could be made slightly more powerful by changing the if retire_request.exists(): to assert retire_request.exists()
jarovo
approved these changes
Nov 14, 2019
digitronik
force-pushed
the
service_retired
branch
2 times, most recently
from
e638729 to
41c3b1b
Compare
digitronik
force-pushed
the
service_retired
branch
from
41c3b1b to
50ea05d
Compare
digitronik
force-pushed
the
service_retired
branch
from
50ea05d to
ad3c1dc
Compare
john-dupuy
approved these changes
Nov 18, 2019
digitronik
force-pushed
the
service_retired
branch
2 times, most recently
from
a60f40d to
6b7fc7d
Compare
digitronik
force-pushed
the
service_retired
branch
from
6b7fc7d to
04b6f3b
Compare
|
I detected some fixture changes in commit 04b6f3b The global fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
approved these changes
Nov 21, 2019
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* moved user_self_service_role as global fixture * is_retired, exists methods * automate retired test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/ssui/test_ssui_myservice.py::test_retire_owned_service --long-running}}