-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] New Test: Test tag delete using automate method #9616
Conversation
0d8a04a
to
928b7a6
Compare
- Testing deletion of tag using automate method Signed-off-by: Ganesh Hubale <[email protected]>
928b7a6
to
6cdb903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions/suggestions. 😄
@pytest.mark.tier(2) | ||
@pytest.mark.meta(blockers=[BZ(1744514)], automates=[1744514]) | ||
@pytest.mark.customer_scenario | ||
def test_delete_tag_from_category(custom_instance): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Whole test is around CRUD via Automate method, test case name should be something like: test_automate_method_delete_tag_from_category
or test_automate_delete_tag_from_category
to have consistency around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to change test name. It is already under automate related files. hence keeping as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @ganeshhubale I agree with you about the test is present in the same file, but looking all of your tests in the same file have suggested name, implementation is up to you 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as there isn't duplication of the test case names across test modules, I think the naming here is fine, as some context is given by the module.
Purpose or Intent
tag_delete
method introduced for deletion of tags under categorytest_create
,tag_exists
etctest_archived_instance_status
andtest_orphaned_instance_status
are already automated in test casetest_power_options_on_archived_instance_all_page
PRT Run
{{ pytest: cfme/tests/automate/test_method.py::test_delete_tag_from_category --use-template-cache -qsvvv }}