Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] New Test: Test tag delete using automate method #9616

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

ganeshhubale
Copy link
Member

Purpose or Intent

  • Testing tag_delete method introduced for deletion of tags under category
  • This test case also goes through methods like test_create, tag_exists etc
  • Note: Test cases test_archived_instance_status and test_orphaned_instance_status are already automated in test case test_power_options_on_archived_instance_all_page

PRT Run

{{ pytest: cfme/tests/automate/test_method.py::test_delete_tag_from_category --use-template-cache -qsvvv }}

    - Testing deletion of tag using automate method

Signed-off-by: Ganesh Hubale <[email protected]>
@ganeshhubale ganeshhubale changed the title [WIPTEST] New Test: Test tag delete using automate method [RFR] New Test: Test tag delete using automate method Nov 14, 2019
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@digitronik digitronik changed the title [RFR] New Test: Test tag delete using automate method [1LP][RFR] New Test: Test tag delete using automate method Nov 15, 2019
Copy link
Contributor

@sbulage sbulage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions/suggestions. 😄

@pytest.mark.tier(2)
@pytest.mark.meta(blockers=[BZ(1744514)], automates=[1744514])
@pytest.mark.customer_scenario
def test_delete_tag_from_category(custom_instance):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
Whole test is around CRUD via Automate method, test case name should be something like: test_automate_method_delete_tag_from_category or test_automate_delete_tag_from_category to have consistency around it.

Copy link
Member Author

@ganeshhubale ganeshhubale Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change test name. It is already under automate related files. hence keeping as it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @ganeshhubale I agree with you about the test is present in the same file, but looking all of your tests in the same file have suggested name, implementation is up to you 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there isn't duplication of the test case names across test modules, I think the naming here is fine, as some context is given by the module.

@mshriver mshriver added test-automation To be applied on PR's which are automating existing manual cases and removed RFR new-test-or-feature labels Nov 19, 2019
@mshriver mshriver merged commit 234c77a into ManageIQ:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants