Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Update the test_db_migrate. #9524

Merged
merged 6 commits into from
Jan 31, 2020
Merged

[1LP][RFR] Update the test_db_migrate. #9524

merged 6 commits into from
Jan 31, 2020

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Oct 22, 2019 •
edited
Loading

  • Add support for resetting the password of AWS credentials when migrating the DB and v2_key is not available. .../cfme-qe-yamls/merge_requests/893 is needed to test this.
  • Add guessing of the db dump format based on the file suffix
  • Add invalidating the cache to resolve:
        @property
        def _rest_api_server(self):
            shref = self.appliance.rest_api.server_info['server_href']
            logger.info(f'server_href: {shref}')
            results = self.appliance.rest_api.collections.servers.all
            logger.info(f'all servers: {results}')
    >       server, = (r for r in results if r.href == shref)
    E       ValueError: not enough values to unpack (expected 1, got 0)
  • Add fixing database.yml using fixauth when the file was not available.

{{pytest: cfme/tests/test_db_migrate.py::test_db_migrate -v}}

@dajoRH dajoRH changed the title [WIPTEST] Add db with ansible creds to test migrations with [WIP] Add db with ansible creds to test migrations with Oct 22, 2019
@jarovo jarovo changed the title [WIP] Add db with ansible creds to test migrations with [WIPTEST] Add db with ansible creds to test migrations with Oct 22, 2019
@dajoRH dajoRH added WIP-testing and removed WIP labels Oct 22, 2019
@dajoRH dajoRH changed the title [WIPTEST] Add db with ansible creds to test migrations with [WIP] Add db with ansible creds to test migrations with Nov 1, 2019
@dajoRH
Copy link
Contributor

dajoRH commented Nov 5, 2019

I detected some fixture changes in commit c0bb5161b368ee7f4f9db966428b5ec5c1f7da65

The local fixture appliance_with_performance_db is used in the following files:

  • cfme/tests/services/test_service_performance.py
    • test_services_performance

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@jarovo jarovo changed the title [WIP] Add db with ansible creds to test migrations with [WIPTEST] Add db with ansible creds to test migrations with Nov 5, 2019
@dajoRH dajoRH added WIP-testing and removed WIP labels Nov 5, 2019
@dajoRH dajoRH changed the title [WIPTEST] Add db with ansible creds to test migrations with [WIP] Add db with ansible creds to test migrations with Nov 15, 2019
@jarovo jarovo changed the title [WIP] Add db with ansible creds to test migrations with [WIPTEST] Add db with ansible creds to test migrations with Nov 18, 2019
@dajoRH dajoRH added WIP-testing and removed WIP labels Nov 18, 2019
@izapolsk izapolsk self-requested a review November 28, 2019 19:04
@jarovo jarovo changed the title [WIPTEST] Add db with ansible creds to test migrations with [RFR] Add db with ansible creds to test migrations with Dec 10, 2019
@jarovo jarovo mentioned this pull request Dec 10, 2019
Merged
@dajoRH dajoRH changed the title [RFR] Add db with ansible creds to test migrations with [WIP] Add db with ansible creds to test migrations with Jan 7, 2020
@jarovo jarovo changed the title [WIP] Add db with ansible creds to test migrations with [WIPTEST] Add db with ansible creds to test migrations with Jan 9, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Jan 9, 2020
@jarovo jarovo changed the title [WIPTEST] Add db with ansible creds to test migrations with [WIPTEST] Update the test_db_migrate. Jan 14, 2020
@jarovo jarovo changed the title [WIPTEST] Update the test_db_migrate. [RFR] Update the test_db_migrate. Jan 27, 2020
@jarovo jarovo changed the title [RFR] Update the test_db_migrate. [WIPTEST] Update the test_db_migrate. Jan 29, 2020
Jaroslav Henner added 6 commits January 30, 2020 17:42
Add DB with encrypted ansible creds.
7483c13
Add guessing of the db format
2e58e87
Make the upgrades from CFME 5.5 conditional.
5741bf2 
as they are not supported when upgrading to CFME 5.10 and higher
Invalidate the rest_api cache in appliance
9730ebf 
This will resolve a problem in here:

    @Property
    def _rest_api_server(self):
        shref = self.appliance.rest_api.server_info['server_href']
        logger.info(f'server_href: {shref}')
        results = self.appliance.rest_api.collections.servers.all
        logger.info(f'all servers: {results}')
>       server, = (r for r in results if r.href == shref)
E       ValueError: not enough values to unpack (expected 1, got 0)
Use the database.yml if available.
f807080
Mark test_db_migrate as automating 1755553
f8b2a50
@jarovo jarovo changed the title [WIPTEST] Update the test_db_migrate. [RFR] Update the test_db_migrate. Jan 30, 2020
john-dupuy
john-dupuy approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small questions, but LGTM

cfme/tests/test_db_migrate.py Show resolved Hide resolved
cfme/tests/test_db_migrate.py Show resolved Hide resolved
@john-dupuy john-dupuy changed the title [RFR] Update the test_db_migrate. [1LP][WIPTEST] Update the test_db_migrate. Jan 31, 2020
@jarovo jarovo changed the title [1LP][WIPTEST] Update the test_db_migrate. [1LP][RFR] Update the test_db_migrate. Jan 31, 2020
@mshriver mshriver self-assigned this Jan 31, 2020
@mshriver mshriver merged commit 16bb944 into ManageIQ:master Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@ganeshhubale ganeshhubale ganeshhubale approved these changes

@mshriver mshriver mshriver approved these changes

@izapolsk izapolsk Awaiting requested review from izapolsk

Assignees

@mshriver mshriver

Labels
enhancement lint-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarovo @dajoRH @mshriver @ganeshhubale @john-dupuy