[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder #9230

ganeshhubale · 2019-08-21T13:47:46Z

Purpose or Intent

This is RFE has exposed move_into_folder to move VMWare vm to custom folder via automate method
Depend on PR: [1LP][RFR] Added functinality to create vm folder in virtualcenter RedHatQE/wrapanapi#407

PRT Run

{{ pytest: cfme/tests/automate/test_common_methods.py::test_move_vm_into_folder --use-provider=complete --use-template-cache -qsvv }}

john-dupuy

Nice test case! LGTM 👍

izapolsk

good PR. I like it. there're two reservations though.

please check my comment
your test hasn't been run in PRT

izapolsk · 2019-08-23T08:26:08Z

cfme/tests/automate/test_common_methods.py

+    """Create Vm folder on VMWare provider"""
+    folder = provider.mgmt.create_folder(f"{fauxfactory.gen_alpha()}")
+    yield folder
+    vm_folder.Destroy()


are you sure there should be vm_folder instead of folder ?

My bad!
It should be folder.
Thanks :)

digitronik · 2019-08-23T09:06:04Z

cfme/tests/automate/test_common_methods.py

+@pytest.fixture(scope="module")
+def vm_folder(provider):
+    """Create Vm folder on VMWare provider"""
+    folder = provider.mgmt.create_folder(f"{fauxfactory.gen_alpha()}")


@ganeshhubale I think, we wont need string formatting here.

kedark3

Looks good, just couple of changes required.

kedark3 · 2019-09-27T17:09:29Z

cfme/tests/automate/test_common_methods.py

+@pytest.fixture(scope="function")
+def vm_folder(provider):
+    """Create Vm folder on VMWare provider"""
+    folder = provider.mgmt.create_folder(fauxfactory.gen_alpha())


This should be prefixed with something meaningful. Please use some context+fauxfactory.gen_alpha()
As a VMware admin I would like to know who is creating the folders.

kedark3 · 2019-09-27T17:10:01Z

cfme/tests/automate/test_common_methods.py

+    """Create Vm folder on VMWare provider"""
+    folder = provider.mgmt.create_folder(fauxfactory.gen_alpha())
+    yield folder
+


REQUIRED: Remove the folder after test is finished.

folder_ does not seem to be a good start for name, maybe add something like test_move_vm_folder_{fauxfactory name} might be longer name but gives more context.

@ganeshhubale please review above suggestion, add little more context to name folder_ .. maybe test_folder_ .

kedark3 · 2019-09-27T17:11:47Z

cfme/tests/automate/test_common_methods.py

+
+    @request.addfinalizer
+    def _finished():
+        fd = vm_folder.Destroy()


I think it should be part of fixture that created the folder.

sbulage

Please check consider suggestion, else LGTM 💯

sbulage · 2019-10-01T11:14:40Z

cfme/tests/automate/test_common_methods.py

@@ -320,3 +321,60 @@ def _finalize():
        assert provision_request.is_succeeded(
            method="ui"
        ), f"Provisioning failed: {provision_request.row.last_message.text}"
+
+
+@pytest.fixture(scope="function")


Suggestion:
@ganeshhubale Can you please move this fixture to above, not in between tests.

… automate method

dajoRH · 2019-12-27T11:05:35Z

I detected some fixture changes in commit 8b0d4cd

The local fixture vm_folder is used in the following files:

cfme/tests/automate/test_common_methods.py
- test_move_vm_into_folder

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

izapolsk · 2019-12-27T12:30:47Z

cfme/tests/automate/test_common_methods.py

+        except CandidateNotFound:
+            return False
+
+    wait_for(lambda: _check, fail_func=view.browser.refresh, timeout=600, delay=5,


OPTIONAL: I'd advice wrapping this into try/except block with pytest.fail next time. currently it will appear broken if this wait_for fails.

…ageIQ#9230) * New Test: This test case checks moving VMWare vm to custom folder via automate method * Updated with requested changes

ganeshhubale mentioned this pull request Aug 21, 2019

[1LP][RFR] Added functinality to create vm folder in virtualcenter RedHatQE/wrapanapi#407

Merged

dajoRH added lint-ok WIP-testing labels Aug 21, 2019

ganeshhubale changed the title ~~[WIPTEST] New Test: Checks moving VMWare vm to custom vm folder~~ [RFR] New Test: Checks moving VMWare vm to custom vm folder Aug 22, 2019

dajoRH removed the WIP-testing label Aug 22, 2019

john-dupuy approved these changes Aug 22, 2019

View reviewed changes

john-dupuy changed the title ~~[RFR] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder Aug 22, 2019

izapolsk added the new-test-or-feature label Aug 23, 2019

izapolsk suggested changes Aug 23, 2019

View reviewed changes

izapolsk changed the title ~~[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][WIP] New Test: Checks moving VMWare vm to custom vm folder Aug 23, 2019

dajoRH added the WIP label Aug 23, 2019

digitronik reviewed Aug 23, 2019

View reviewed changes

ganeshhubale changed the title ~~[1LP][WIP] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][WIPTEST] New Test: Checks moving VMWare vm to custom vm folder Aug 23, 2019

dajoRH added WIP-testing and removed WIP labels Aug 23, 2019

dajoRH changed the title ~~[1LP][WIPTEST] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][WIP] New Test: Checks moving VMWare vm to custom vm folder Aug 23, 2019

dajoRH added needs-rebase WIP and removed WIP-testing labels Aug 23, 2019

ganeshhubale force-pushed the move_into branch from ae0f234 to 4cb7d11 Compare August 27, 2019 12:14

dajoRH removed the needs-rebase label Aug 27, 2019

ganeshhubale changed the title ~~[1LP][WIP] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][WIPTEST] New Test: Checks moving VMWare vm to custom vm folder Aug 30, 2019

ganeshhubale force-pushed the move_into branch from 4cb7d11 to 0b1e002 Compare August 30, 2019 12:54

dajoRH added WIP-testing and removed WIP labels Aug 30, 2019

dajoRH changed the title ~~[1LP][WIPTEST] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][WIP] New Test: Checks moving VMWare vm to custom vm folder Sep 5, 2019

dajoRH added needs-rebase WIP and removed WIP-testing labels Sep 5, 2019

ganeshhubale force-pushed the move_into branch from 0b1e002 to bdce549 Compare September 6, 2019 09:28

ganeshhubale force-pushed the move_into branch 5 times, most recently from 101701f to a78db9b Compare September 23, 2019 12:17

dajoRH added needs-lint and removed lint-ok labels Sep 23, 2019

ganeshhubale force-pushed the move_into branch from a78db9b to 0165d27 Compare September 23, 2019 12:43

dajoRH added lint-ok and removed needs-lint labels Sep 23, 2019

ganeshhubale force-pushed the move_into branch from 0165d27 to c61b597 Compare September 25, 2019 10:55

kedark3 suggested changes Sep 27, 2019

View reviewed changes

sbulage suggested changes Oct 1, 2019

View reviewed changes

ganeshhubale force-pushed the move_into branch 3 times, most recently from 3f0fe5c to b3ae9b9 Compare October 9, 2019 10:22

ganeshhubale force-pushed the move_into branch 2 times, most recently from 5e27c5b to d969923 Compare December 3, 2019 06:40

ganeshhubale force-pushed the move_into branch from d969923 to 6fd3f97 Compare December 26, 2019 06:38

Ganesh Hubale added 2 commits December 27, 2019 15:08

New Test: This test case checks moving VMWare vm to custom folder via…

4b3cd9a

… automate method

Updated with requested changes

8b0d4cd

ganeshhubale force-pushed the move_into branch from 6fd3f97 to 8b0d4cd Compare December 27, 2019 11:03

ganeshhubale changed the title ~~[1LP][WIPTEST] New Test: Checks moving VMWare vm to custom vm folder~~ [1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder Dec 27, 2019

dajoRH removed the WIP-testing label Dec 27, 2019

izapolsk self-requested a review December 27, 2019 11:52

izapolsk approved these changes Dec 27, 2019

View reviewed changes

izapolsk merged commit 60b048f into ManageIQ:master Dec 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder #9230

[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder #9230

ganeshhubale commented Aug 21, 2019 •

edited

Loading

john-dupuy left a comment

izapolsk left a comment

izapolsk Aug 23, 2019

ganeshhubale Aug 23, 2019

digitronik Aug 23, 2019

kedark3 left a comment

kedark3 Sep 27, 2019

kedark3 Sep 27, 2019

kedark3 Oct 9, 2019

kedark3 Dec 2, 2019

kedark3 Sep 27, 2019

sbulage left a comment

sbulage Oct 1, 2019

dajoRH commented Dec 27, 2019

izapolsk Dec 27, 2019 •

edited

Loading

[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder #9230

[1LP][RFR] New Test: Checks moving VMWare vm to custom vm folder #9230

Conversation

ganeshhubale commented Aug 21, 2019 • edited Loading

Purpose or Intent

PRT Run

john-dupuy left a comment

Choose a reason for hiding this comment

izapolsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kedark3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbulage left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dajoRH commented Dec 27, 2019

izapolsk Dec 27, 2019 • edited Loading

Choose a reason for hiding this comment

ganeshhubale commented Aug 21, 2019 •

edited

Loading

izapolsk Dec 27, 2019 •

edited

Loading