Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] ParametrizedSummaryTable.is_displayed support #6835

Closed

Conversation

izapolsk
Copy link
Contributor

@izapolsk izapolsk commented Mar 7, 2018

I see two ways to fix this:

  1. add locator
  2. copy SummaryTable.BASELOC to ParametrizedSummaryTable.ROOT + ParametrizedString

I chose first way.

@mshriver
Copy link
Member

mshriver commented Mar 7, 2018

I definitely prefer this solution to option #2. I also think directly implementing ParametrizedSummaryTable.is_displayed (returning self._table.is_displayed) would be a good approach since this class is a ParametrizedView, not a widget, and doesn't really have its own locator. All of its methods are just wrapping calls to SummaryTable. through self._table.

@mshriver mshriver changed the title [RFR] ParametrizedSummaryTable.is_displayed support [1LP][RFR] ParametrizedSummaryTable.is_displayed support Mar 7, 2018
Copy link
Contributor

@mfalesni mfalesni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need to figure out how to parametrize a single widget, instead of having workarounds with a view containing a "private" widget. :)

@@ -603,6 +603,9 @@ class ParametrizedSummaryTable(ParametrizedView):
PARAMETERS = ("title", )
_table = SummaryTable(title=Parameter("title"))

def __locator__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT failures look directly related, as they're failing to find the Relationships table on provider details for stat validation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally and observed the same failures. I tried a different fix by implementing is_displayed within ParametrizedSummaryTable and

@property
    def is_displayed(self):
        return self._table.is_displayed

Failures were not observed with this fix. Maybe an alternate fix?

@izapolsk
Copy link
Contributor Author

izapolsk commented Mar 9, 2018

@mfalesni, honestly, I think we have to remove that private widget and move code to primary table instead. But this change requires some efforts. so, I don't consider it atm :)

@izapolsk izapolsk closed this Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants