This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Check V2_key perms #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure in 58z is expected as the change has not been back-ported. |
psav
suggested changes
Oct 13, 2017
| from cfme.utils import version | ||
|
|
||
|
|
||
| @pytest.mark.uncollectif(lambda: version.current_version() < '5.6', reason='Only valid for >5.7') |
There was a problem hiding this comment.
REQUIRED: This line can go, the framework is not valid for 5.6 and below
| @pytest.mark.uncollectif(lambda: version.current_version() < '5.6', reason='Only valid for >5.7') | ||
| def test_v2_key_permissions(appliance): | ||
| """Verifies that the v2_key has proper permissions""" | ||
| stdout = appliance.ssh_client.run_command( |
There was a problem hiding this comment.
You should be able to do
stdout = appliance.ssh_client.run_command(........).output
assert int(stdout) == 400
psav
suggested changes
Oct 13, 2017
rlbabyuk
approved these changes
Oct 17, 2017
mfalesni
approved these changes
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for file permissions on appliance