This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Conversion of shell calls into REST calls, part #1 #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self.db.client.session.query( | ||
| miq_servers.id).filter(miq_servers.guid == self.guid)[0][0] | ||
| try: | ||
| server = self.rest_api.get_entity_by_href(self.rest_api.server_info['server_href']) |
There was a problem hiding this comment.
this piece seems to be duplicated a lot, perhaps a helper can cut the code short
There was a problem hiding this comment.
Yeh, server_info api fields could have a getter method on appliance.
added 6 commits
September 5, 2017 18:26
mfalesni
changed the title
mkoura
changed the title
psav
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.