Table + Containers - Handle hiding, and fixup containers code. #2984
Conversation
|
looks good the @landscape-bot is drunk |
|
@RonnyPfannschmidt I added a couple of other changes, yelling when it cannot find the row when clicking a single row and also ./ in the xpath expressions |
mfalesni
changed the title
|
|
|
@RonnyPfannschmidt I don't think that would work for all use cases, however a simplification could be done, I was thinking about it: You could just pass objects as class Foo(object):
context_name = 'foo'
foo = Foo()
force_navigate('bar', foo)
# inside navigation
args = [<Foo instance 0xbar>]
# will be converted to
args = {'foo': <Foo instance 0xbar>} |
Handle hiding of the table. Involves the .rows() and the things that use it directly. The other things will eventually need this change too once needed. I also added an exception when you click a row and it is not found. Removed the convert_header in favour of attributize_string from the utils which does the same. Fixups in some places in tables.
|
Lint report for commit fd819d5: Everything seems all right 😄 . |
| {'Name': ctx['container'].name, 'Pod Name': ctx['pod'].name}), | ||
| { | ||
| 'containers_container_edit_tags': | ||
| lambda _: pol_btn('Edit Tags'), |
There was a problem hiding this comment.
We are removing navigation points here......is that a good idea?
There was a problem hiding this comment.
They are not used in the code
|
Looks good; 5.6 has a single failure that is not caused by this PR. |
Handle hiding of the table. Phase #1 involves the .rows() and the things that use it directly. The other things will eventually need this change too once needed.
{{pytest: cfme/tests/containers/test_relationships_tables.py -v --long-running}}