This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Automated test to validate chargeback report #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachandr
changed the title
| def cleanup_report(report): | ||
| return lambda: _cleanup_report(report) | ||
|
|
||
| request.addfinalizer(cleanup_report(report)) |
There was a problem hiding this comment.
@request.addfinalizer
def cleanup():
_cleanup_report(report)
| enterprise.storageassign() | ||
|
|
||
|
|
||
| class cost: |
There was a problem hiding this comment.
Two things here,
(1 Why use a class for this? Wouldn't a dict do?
(2 Is it supposed to be instantiated and used at the module level?
nachandr
force-pushed
the
validate_chargeback_report
branch
from
d7f88cf
to
251b168
Compare
nachandr
force-pushed
the
validate_chargeback_report
branch
2 times, most recently
from
10079d9
to
794dcc2
Compare
nachandr
changed the title
nachandr
force-pushed
the
validate_chargeback_report
branch
2 times, most recently
from
d901b3f
to
4393f80
Compare
| for i, argvalue_tuple in enumerate(argvalues): | ||
| args = dict(zip(argnames, argvalue_tuple)) | ||
|
|
||
| try: |
There was a problem hiding this comment.
This section shouldn't be needed as you have the required fields above on line 20
nachandr
force-pushed
the
validate_chargeback_report
branch
3 times, most recently
from
09e5997
to
680ab4d
Compare
|
@nachandr The tests are missing tier marker, also maybe the test comments (descriptions) could be more elaborate with steps. |
nachandr
force-pushed
the
validate_chargeback_report
branch
2 times, most recently
from
229578d
to
7c6e76c
Compare
| average_network_io = resource_usage['average_network_io'] | ||
| average_disk_io = resource_usage['average_disk_io'] | ||
|
|
||
| # Estimate Chargeback costs using default Chargeback rate and resource usage. |
There was a problem hiding this comment.
def calc_rate(rate_name, description, type)
with db.transaction:
providers = (
db.session.query(details.id)
.join(rates, details.chargeback_rate_id == rates.id)
.filter(details.metric == rate_name, rates.description == description,
rates.rate_type == type)
)
cpu_rate = db.session.query(details).filter(details.id.in_(
providers.subquery())).first().rate
cpu_rate = calc_rate('cpu_usagemhz_rate_average', 'Default', 'Compute')
cpu_used_cost = average_cpu_used_in_mhz * float(cpu_rate) / 24There was a problem hiding this comment.
@psav Done.Taken care of that.
nachandr
force-pushed
the
validate_chargeback_report
branch
from
7c6e76c
to
51059ce
Compare
nachandr
force-pushed
the
validate_chargeback_report
branch
from
1512c9a
to
ac88ac9
Compare
nachandr
changed the title
nachandr
force-pushed
the
validate_chargeback_report
branch
from
ac88ac9
to
a4495c2
Compare
nachandr
changed the title
nachandr
force-pushed
the
validate_chargeback_report
branch
6 times, most recently
from
87cc170
to
0b7d2ed
Compare
| cb_group = ac.Group(description='EvmGroup-super_administrator') | ||
| user = ac.User(name=provider.name + fauxfactory.gen_alphanumeric(), | ||
| credential=new_credential(), | ||
| email='[email protected]', |
nachandr
force-pushed
the
validate_chargeback_report
branch
3 times, most recently
from
9510eb6
to
3c8417a
Compare
nachandr
force-pushed
the
validate_chargeback_report
branch
6 times, most recently
from
31a043c
to
21d3faf
Compare
nachandr
force-pushed
the
validate_chargeback_report
branch
from
21d3faf
to
36ab74a
Compare
nachandr
force-pushed
the
validate_chargeback_report
branch
from
36ab74a
to
7093bf5
Compare
|
Lint report for commit 7093bf5: Everything seems all right 😄 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.