Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[RFR] Fix to switch_to.alert call #10238

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[RFR] Fix to switch_to.alert call #10238

merged 1 commit into from
Jul 7, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Jul 6, 2020

In PR #10237 the fix to replace deprecated switch_to_alert() with the property method switch_to.alert incorrectly used switch_to.alert(), which led to errors like the following when a popup / alert is found:

        try:
>           return self.selenium.switch_to.alert()
E           TypeError: 'Alert' object is not callable

cfme/utils/appliance/implementations/common.py:38: TypeError (cfme/fixtures/log.py:84)

This PR makes the fix and includes a PRT test that ran into this problem.

{{ pytest: -v -k test_zone_crud cfme/tests/configure/test_zones.py }}

@tpapaioa tpapaioa changed the title [WIPTEST] Fix to switch_to.alert call [RFR] Fix to switch_to.alert call Jul 6, 2020
@mshriver mshriver merged commit a27cc25 into ManageIQ:master Jul 7, 2020
@tpapaioa tpapaioa deleted the fix_switch_to_alert branch July 7, 2020 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants